656992 - 546 lines of build warning spam from "NeckoMessageUtils.h:* warning: unused variable 'rv'"

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Daniel Holbert [:dholbert]]

When building an opt build, we get 546 lines of this build-warning-spam:
> NeckoMessageUtils.h: In static member function 'static void IPC::ParamTraits<IPC::InputStream>::Write(IPC::Message*, const IPC::ParamTraits<IPC::InputStream>::paramType&)':
> NeckoMessageUtils.h:219:18: warning: unused variable 'rv'
> NeckoMessageUtils.h:230:14: warning: unused variable 'rv'

(Apparently lots of files include that header, directly or indirectly)

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix: use mozilla::DebugOnly<nsresult>

This fixes these spots using the magical new DebugOnly template.*

I've also fixed one existing instance of...
  #ifdef DEBUG
     nsresult rv = 
  #endif
      // some expression
      // sanity-check rv

...to use DebugOnly, too.

* https://developer.mozilla.org/index.php?title=En/Namespace/Mozilla/DebugOnly%3CT%3E

Comment 2

[Jason Duell]

Comment on attachment 532321 [details] [diff] [review]
fix: use mozilla::DebugOnly<nsresult>

What do you know--every once in a while C++ is actually slick in an almost straightforward way.   Thanks for the patch!

Comment 3

[Daniel Holbert [:dholbert]]

Thanks for the speedy review!
http://hg.mozilla.org/projects/cedar/rev/cf70935c912b

Comment 4

[Jason Duell]

http://hg.mozilla.org/mozilla-central/rev/cf70935c912b