Last Comment Bug 657120 - TI+JM: incorrect result with JSOP_AND, JSOP_LT
: TI+JM: incorrect result with JSOP_AND, JSOP_LT
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: ---
Assigned To: Jan de Mooij [:jandem]
:
: Jason Orendorff [:jorendorff]
Mentors:
Depends on:
Blocks: infer-regress
  Show dependency treegraph
 
Reported: 2011-05-14 06:00 PDT by Jan de Mooij [:jandem]
Modified: 2011-05-17 05:14 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (2.76 KB, patch)
2011-05-16 04:59 PDT, Jan de Mooij [:jandem]
bhackett1024: review+
Details | Diff | Splinter Review

Description Jan de Mooij [:jandem] 2011-05-14 06:00:16 PDT
--
function f() {
    var x = Object(2);
    var y = 3.14;
    assertEq(true && x < y, true);
}
f();
--
$ ./js -n -m -a test.js
test.js:4: Error: Assertion failed: got false, expected true

Revision b92ac5a4ef47, 32-bit OS X. Old regression though, I can reproduce with a build from January.
Comment 1 Jan de Mooij [:jandem] 2011-05-16 04:59:41 PDT
Created attachment 532611 [details] [diff] [review]
Patch

In jsop_relational_double, syncExit for the lhs has to be called before loading the rhs. I thought about adding a helper function but this pattern is not that common so I went with the straight-forward fix; suggestions welcome.
Comment 2 Jan de Mooij [:jandem] 2011-05-17 05:14:08 PDT
http://hg.mozilla.org/projects/jaegermonkey/rev/807a6cc25c34

Note You need to log in before you can comment on or make changes to this bug.