TI+JM: incorrect result with JSOP_AND, JSOP_LT

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
--
function f() {
    var x = Object(2);
    var y = 3.14;
    assertEq(true && x < y, true);
}
f();
--
$ ./js -n -m -a test.js
test.js:4: Error: Assertion failed: got false, expected true

Revision b92ac5a4ef47, 32-bit OS X. Old regression though, I can reproduce with a build from January.
(Assignee)

Updated

6 years ago
Assignee: general → jandemooij
Status: NEW → ASSIGNED
(Assignee)

Comment 1

6 years ago
Created attachment 532611 [details] [diff] [review]
Patch

In jsop_relational_double, syncExit for the lhs has to be called before loading the rhs. I thought about adding a helper function but this pattern is not that common so I went with the straight-forward fix; suggestions welcome.
Attachment #532611 - Flags: review?(bhackett1024)
Attachment #532611 - Flags: review?(bhackett1024) → review+
(Assignee)

Comment 2

6 years ago
http://hg.mozilla.org/projects/jaegermonkey/rev/807a6cc25c34
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.