Closed Bug 657131 Opened 11 years ago Closed 11 years ago

Create a new Execute menu for Scratchpad

Categories

(DevTools :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 6

People

(Reporter: rcampbell, Assigned: rcampbell)

References

Details

(Whiteboard: [scratchpad][fixed-in-devtools][merged-to-mozilla-central])

Attachments

(1 file, 3 obsolete files)

Move "Execute, Inspect, Print" from the Edit menu to a new Execute
menu: "Execute", "Inspect value", "Append value as comment".
Hardware: ARM → All
Assignee: nobody → rcampbell
Status: NEW → ASSIGNED
this is going to be the third top-level menu beginning with the letter E. Just sayin'.
Depends on: 657136
Attached patch execute menu (obsolete) — Splinter Review
execute menu with renames for Execute, Inspect, Print (Run, Inspect, Display).
Attachment #533402 - Flags: review?(mihai.sucan)
Attached patch execute menu (obsolete) — Splinter Review
removed extraneous separator from edit menu
Attachment #533402 - Attachment is obsolete: true
Attachment #533402 - Flags: review?(mihai.sucan)
Attachment #533567 - Flags: review?(mihai.sucan)
Attached patch execute menu (obsolete) — Splinter Review
renamed execute to run and print to display. Updated method names in scratchpad.js and in unittests.
Attachment #533567 - Attachment is obsolete: true
Attachment #533567 - Flags: review?(mihai.sucan)
Attachment #533583 - Flags: review?(mihai.sucan)
Comment on attachment 533583 [details] [diff] [review]
execute menu

Review of attachment 533583 [details] [diff] [review]:
-----------------------------------------------------------------

Patch is fine, just some minor nits. r+!

::: browser/base/content/scratchpad.xul
@@ +246,1 @@
>        <menuitem id="sp-text-execute"

This ID needs to be sp-text-run.

::: browser/base/content/test/browser_scratchpad_ui.js
@@ +37,1 @@
>      "sp-text-inspect": "inspect",

Somehow I forgot sp-text-display when I wrote the test. Please add it.
Attachment #533583 - Flags: review?(mihai.sucan) → review+
Blocks: 653108
corrected based on feedback.
Attachment #533583 - Attachment is obsolete: true
Attachment #533716 - Flags: review?(sdwilsh)
Comment on attachment 533716 [details] [diff] [review]
[in-devtools] execute menu 2

Review of attachment 533716 [details] [diff] [review]:
-----------------------------------------------------------------

r=sdwilsh
Attachment #533716 - Flags: review?(sdwilsh) → review+
Whiteboard: [scratchpad] → [scratchpad][fixed-in-devtools]
Comment on attachment 533716 [details] [diff] [review]
[in-devtools] execute menu 2

http://hg.mozilla.org/projects/devtools/rev/2a10e886f3d7
Attachment #533716 - Attachment description: execute menu 2 → [in-devtools] execute menu 2
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [scratchpad][fixed-in-devtools] → [scratchpad][fixed-in-devtools][merged-to-mozilla-central]
Target Milestone: --- → Firefox 6
Verified fixed on:
Windows 7:
Mozilla/5.0 (Windows NT 6.1; rv:6.0a2) Gecko/20110525 Firefox/6.0a2
Window XP:
Mozilla/5.0 (Windows NT 5.1; rv:6.0a2) Gecko/20110525 Firefox/6.0a2
Mac OS 10.6
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:6.0a2) Gecko/20110525 Firefox/6.0a2 
Linux i686:
Mozilla/5.0 (X11; Linux i686; rv:6.0a2) Gecko/20110525 Firefox/6.0a2

*Note: In Scratchpad, under Execute the following options are available: Run, Inspect, Display. Marking this as Verified.
Status: RESOLVED → VERIFIED
Duplicate of this bug: 656544
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.