657150 - Should Check for Whether Installation Is Enabled Before Navigating to .xpi File

Status: RESOLVED INACTIVE

(Toolkit :: Add-ons Manager, defect)

Description

[David E. Ross]

User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0.1) Gecko/20110511 SeaMonkey/2.1
Build Identifier: 

For safety, I normally have my preferences set to disable installation of extensions.  When I install an extension, I first download the .xpi file and then install from my hard drive.  

When I go to install an extension from my hard drive, Add-ons Manager first has me navigate to the .xpi file and then informs me that installation is disabled.  I must then enable installation and again navigate to the .xpi file.  

The proper order should be to check whether installation is enabled before requesting any navigation to the file.  


Reproducible: Always

Steps to Reproduce:
1.  Download an .xpi file for an extension.  

2.  With about:config, set xpinstall.enabled to "false".  

3.  Attempt to use Add-on Manager to "Install add-on from file".  

Actual Results:  
First, you are requested to navigate to the .xpi file.  Then, you are requested to enable installation.  Finally, you are again requested to navigate to the .xpi file.  

Expected Results:  
You should first be requested to enable installation before any request to navigate to the .xpi file.

Comment 1

[Dave Townsend [:mossop]]

Probably should just disable or hide the install option in that case.

Comment 2

[David E. Ross]

NO!  I set xpinstall.enabled to "false" in my user.js file for safety.  I want to explicitly enable each installation.  Before, Add-ons Manager provided the option to do such enabling and did so before requesting the .xpi file.  That should not have been changed.

Comment 3

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.