Finish off the removal of content_xmldoc.xpt

RESOLVED FIXED in mozilla7

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: philor, Assigned: philor)

Tracking

Trunk
mozilla7
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 532528 [details] [diff] [review]
Fix v.1

Bug 457102 removed all the .idls in content/xml/document/public/, but left the XPIDL_MODULE = content_xmldoc behind, which makes packaging warn about a "package error or possible missing or unnecessary file: bin/components/content_xmldoc.xpt" since we don't create an empty one.

There's some risk to removing the XPIDL_MODULE, since if someone throws a .idl in there sometime later, and sees that it winds up in content.xpt, they need to make the right decision and put an XPIDL_MODULE back in, rather than trying to ship content.xpt (which the updater removes on OS X, because we accidentally shipped one there at one point), but since I don't know how to do khuey's suggestion, get rid of nsIXMLContentSink and thus get rid of the whole public directory, this is the best I can do.
Attachment #532528 - Flags: review?(bzbarsky)
Blocks: 657208
Depends on: 457102
Flags: in-testsuite-

Comment 1

6 years ago
Comment on attachment 532528 [details] [diff] [review]
Fix v.1

r=me
Attachment #532528 - Flags: review?(bzbarsky) → review+
http://hg.mozilla.org/mozilla-central/rev/2c7a0ec1fd83
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
You need to log in before you can comment on or make changes to this bug.