Closed Bug 657251 Opened 10 years ago Closed 10 years ago

Finish off the removal of content_xmldoc.xpt

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla7

People

(Reporter: philor, Assigned: philor)

References

Details

Attachments

(1 file)

Fix v.1
2.11 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review
Attached patch Fix v.1 — — Splinter Review 
Bug 457102 removed all the .idls in content/xml/document/public/, but left the XPIDL_MODULE = content_xmldoc behind, which makes packaging warn about a "package error or possible missing or unnecessary file: bin/components/content_xmldoc.xpt" since we don't create an empty one.

There's some risk to removing the XPIDL_MODULE, since if someone throws a .idl in there sometime later, and sees that it winds up in content.xpt, they need to make the right decision and put an XPIDL_MODULE back in, rather than trying to ship content.xpt (which the updater removes on OS X, because we accidentally shipped one there at one point), but since I don't know how to do khuey's suggestion, get rid of nsIXMLContentSink and thus get rid of the whole public directory, this is the best I can do.
Attachment #532528 - Flags: review?(bzbarsky)
Depends on: 457102
Flags: in-testsuite-
Comment on attachment 532528 [details] [diff] [review]
Fix v.1

r=me
Attachment #532528 - Flags: review?(bzbarsky) → review+
http://hg.mozilla.org/mozilla-central/rev/2c7a0ec1fd83
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.