Closed
Bug 657285
Opened 14 years ago
Closed 14 years ago
No contrib directory for Firefox 5.0b1
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ginnchen+exoracle, Assigned: lsblakk)
References
Details
Attachments
(1 file)
1.69 KB,
patch
|
rail
:
review+
|
Details | Diff | Splinter Review |
contrib directory is not created in either nightly or releases.
Comment 1•14 years ago
|
||
Ginn, fwiw I'm not a Firefox releng guy so they could certainly tell me I'm wrong here.
But I don't think the lack of a contrib directory (or the creation of one) played into their plans with beta 1, since it was not a "real" beta, but more akin to an alpha build created to test the channel-switcher feature in Firefox 5/6.
There was a need to test that feature prior to Firefox 5 moving to the new beta tree, and that is why they created it. There will be a new beta within the next few days, which I would expect to have a contrib dir like normal.
Comment 2•14 years ago
|
||
lsblakk could you please have a look on why the signing scripts did not create the contrib directory?
Assignee | ||
Comment 3•14 years ago
|
||
Added the contrib, contrib-localized and KEY to 5.0b1 dir
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 4•14 years ago
|
||
What happened that they were not created?
Assignee | ||
Comment 5•14 years ago
|
||
just had to do the contrib dirs manually - used the Makefile but it needed $(WORKDIR) in a couple of places so that I could make it work
Attachment #532707 -
Flags: review?(rail)
Assignee | ||
Comment 6•14 years ago
|
||
(In reply to comment #4)
> What happened that they were not created?
Not being able to use autosign because of only doing en-US builds - and there's not a section in the old signing notes for creating contrib dirs when you sign manually (not that I hit anyway).
Comment 7•14 years ago
|
||
Thanks! I had the feeling that it had to do with creating en-US only release.
Good to know.
Comment 8•14 years ago
|
||
Comment on attachment 532707 [details] [diff] [review]
add $(WORKDIR) to a couple of make targets in autosign makefile
Looks good.
Attachment #532707 -
Flags: review?(rail) → review+
Updated•12 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•