Closed Bug 657292 Opened 13 years ago Closed 13 years ago

Firefox 6.0a1 Crash Report [@ xpc::XrayWrapper<JSCrossCompartmentWrapper>::createHolder(JSContext*, JSObject*, JSObject*) ][@ xpc::XrayWrapper<JSCrossCompartmentWrapper>::createHolder ]


(Core :: JavaScript Engine, defect)

Not set



Tracking Status
firefox5 + fixed
firefox6 + fixed


(Reporter: Honza, Assigned: mrbkap)



(Keywords: crash, regression, Whiteboard: [firebug-p1] fixed-in-tracemonkey [tracking requirement in comment 28])

Crash Data


(2 files)

Marking as Firebug-p1 since this is blocking Firebug team from testing on nightlies.

Whiteboard: [firebug-p1]
Yet another way how to see the exact regression range:
(started crashing on Sat: 14 May 2011 01:19:01 GMT, App Changeset: c2bea9fde3b0)

Version: 1.9.1 Branch → Trunk
There's a tracemonkey merge in there...

Trying out hourly builds I got to this:
As of yesterday, this is the #1 crash on trunk with roughly 10% of all trunk crashes!
All the 6.0a1 crashes I checked in do have Firebug installed - but there are a few 4.0.1 crashes with the same signature (probably some other cause) and those don't have Firebug installed.

Still, the Nightly+Firebug problem is the immediate one, we should get that fixed, ideally before this code goes into Aurora next week.
jorge: can you try Tracemonkey nightlies and/or hourlies?
Assignee: nobody → general
Severity: normal → critical
Component: XPConnect → JavaScript Engine
Keywords: regression
QA Contact: xpconnect → general
ccing some of the people in that range too.
Happens on Mac as well, 
[@ xpc::XrayWrapper<JSCrossCompartmentWrapper>::createHolder ]
OS: Windows Vista → All
Hardware: x86 → All
BTW, is there an easier way to browse and test these builds?
Doing it manually is a bit error-prone.
Blake, this looks like a regression from bug 641342.

All the crashes are at 0x10, which looks like a null deref somewhere here.

This code:

    2.15 +        JSObject *inner = obj;
    2.16 +        OBJ_TO_INNER_OBJECT(cx, inner);
    2.17 +        XPCWrappedNative *wn;
    2.18 +        if (IS_WN_WRAPPER(inner) &&
    2.19 +            (wn = static_cast<XPCWrappedNative *>(inner->getPrivate()))->HasProto() &&
    2.20 +            wn->GetProto()->ClassIsDOMObject()) {
    2.21 +            typedef XrayWrapper<JSCrossCompartmentWrapper> Xray;
    2.22 +            wrapper = &FilteringWrapper<Xray,
    2.23 +                                        CrossOriginAccessiblePropertiesOnly>::singleton;
    2.24 +            xrayHolder = Xray::createHolder(cx, obj, parent);

looks to me like a gc hazard if |inner| can go away while |obj| stays around, since nothing is using |inner| in this case after we get |wn|.  Can inner go away that way?
Assignee: general → mrbkap
Blocks: 641342
Summary: Firefox 6.0a1 Crash Report [@ xpc::XrayWrapper<JSCrossCompartmentWrapper>::createHolder(JSContext*, JSObject*, JSObject*) ] → Firefox 6.0a1 Crash Report [@ xpc::XrayWrapper<JSCrossCompartmentWrapper>::createHolder(JSContext*, JSObject*, JSObject*) ][@ xpc::XrayWrapper<JSCrossCompartmentWrapper>::createHolder ]
Attached patch Proposed fixSplinter Review
In practice inner and outer are related, so there's no GC hazard there. That being said, I cleaned up the code a little bit. The actual fix is checking targetdata before trying to create the Xray wrapper.

Do note that I haven't actually been able to reproduce the crash. But based on crash stacks, this has to be the fix.
Attachment #534029 - Flags: review?(gal)
Blocks: 657125
(In reply to comment #14)
Applying the patch to current mozilla-central fixes the problem on my end.

Latest nightly still crashes.
Attachment #534029 - Flags: review?(gal) → review+
Whiteboard: [firebug-p1] → [firebug-p1] fixed-in-tracemonkey
Still crashes in the latest Nightly channel. This bug blocks me to test Firebug on Nightlies and so, I have no idea whether there are any other problems raising.

Closed: 13 years ago
Resolution: --- → FIXED
(In reply to comment #18)

Nice! If this works out, we'll want it on aurora as well, I guess, as this crash should be on Aurora 6 now.
Attachment #534029 - Flags: approval-mozilla-beta?
Attachment #534029 - Flags: approval-mozilla-aurora?
Whiteboard: [firebug-p1] fixed-in-tracemonkey → [firebug-p1] fixed-in-tracemonkey nominated at comment 20
For me it is still not fixed yet. See
Or didn't your fix make it into the latest nightly yet?
Yep.  Blake's push was at 2011-05-26 06:15 Pacific, while that crash report is from a nightly that was pulled at 2011-05-26 03:05 Pacific.
Thanks, now the nightlies are finally working again. Though it seems the error now leaked into Aurora:
So hopefully there'll be an update soon.
Attachment #534029 - Flags: approval-mozilla-beta?
Attachment #534029 - Flags: approval-mozilla-beta+
Attachment #534029 - Flags: approval-mozilla-aurora?
Attachment #534029 - Flags: approval-mozilla-aurora+
(In reply to comment #24)
> Though it seems the
> error now leaked into Aurora

That's why approval‑mozilla‑aurora had been requested and now granted, the latter meaning that the fix will soon be pushed there (a comment here will be made about this) and then fixed Aurora builds will appear.
Blake, can you please land this on Aurora? The last builds on trunk that are seeing this crash are the nightlies from before you checked in on m-c, but Aurora is still hitting this significantly. This crash now takes the two top spots in 6.0a2 topcrashes...
Whiteboard: [firebug-p1] fixed-in-tracemonkey nominated at comment 20 → [firebug-p1] fixed-in-tracemonkey [tracking requirement in comment 28]
Verified on Mozilla/5.0 (Windows NT 5.1; rv:5.0) Gecko/20100101 Firefox/5.0 - 5b5 and also on Mac OS X 10.6, Ubuntu 10.10 x86 and Win7 using the steps from Description.

Issue no longer present - setting status to Verified Fixed.
Crash Signature: [@ xpc::XrayWrapper<JSCrossCompartmentWrapper>::createHolder(JSContext*, JSObject*, JSObject*) ] [@ xpc::XrayWrapper<JSCrossCompartmentWrapper>::createHolder ]
Keywords: crash
You need to log in before you can comment on or make changes to this bug.