Closed
Bug 657396
Opened 13 years ago
Closed 13 years ago
code coverage builds busted in elfhack
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla6
People
(Reporter: ted, Assigned: glandium)
References
()
Details
Attachments
(1 file)
1.00 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
These used to break in JS, now they're broken in elfhack, probably fallout from GCC 4.5/PGO: /tools/gcc-4.5/bin/g++ -fno-rtti -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-variadic-macros -Werror=return-type -Wno-long-long -fprofile-arcs -ftest-coverage -fno-strict-aliasing -std=gnu++0x -pthread -pipe -fexceptions -DDEBUG -D_DEBUG -DTRACING -g -fPIC -shared -Wl,-z,defs -Wl,-h,test.so -o test.so test.o === === If you get failures below, please file a bug describing the error === and your environment (compiler and linker versions), and use === --disable-elf-hack until this is fixed. === /builds/slave/cen-lnx-codecoverage/build/objdir/build/unix/elfhack/elfhack -b test.so test.so: Reduced by 3984 bytes # Fail if the backup file doesn't exist [ -f "test.so.bak" ] # Fail if the new library doesn't contain less relocations [ $(objdump -R test.so.bak | wc -l) -gt $(objdump -R test.so | wc -l) ] /tools/gcc-4.5/bin/gcc -lpthread -lgcov -static-libgcc -Wl,-rpath-link,/builds/slave/cen-lnx-codecoverage/build/objdir/dist/bin -Wl,-rpath-link,/usr/local/lib -o dummy dummy.o test.so dummy.o: In function `global constructors keyed to 65535_0_dummy.c': /builds/slave/cen-lnx-codecoverage/build/build/unix/elfhack/dummy.c:5: undefined reference to `__gcov_init' dummy.o:(.data.rel+0x24): undefined reference to `__gcov_merge_add' collect2: ld returned 1 exit status NEXT ERROR make[7]: *** [dummy] Error 1
Assignee | ||
Comment 1•13 years ago
|
||
Can't reproduce locally with the code-coverage mozconfig :-/
Assignee | ||
Comment 2•13 years ago
|
||
I managed to reproduce, and fix.
Attachment #532694 -
Flags: review?(ted.mielczarek)
Reporter | ||
Updated•13 years ago
|
Attachment #532694 -
Flags: review?(ted.mielczarek) → review+
Reporter | ||
Updated•13 years ago
|
Assignee: nobody → mh+mozilla
Assignee | ||
Comment 3•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/14bbc2fa43a7
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•