The default bug view has changed. See this FAQ.

Missing include guards in nsTimeRange class

RESOLVED FIXED in mozilla6

Status

()

Core
DOM
--
trivial
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: padenot, Assigned: padenot)

Tracking

Trunk
mozilla6
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

6 years ago
There is no include guards in this .h file.
(Assignee)

Updated

6 years ago
Assignee: nobody → paul
(Assignee)

Comment 1

6 years ago
Created attachment 532722 [details] [diff] [review]
Patch v1, adding input guards
Attachment #532722 - Flags: review?(chris)
Comment on attachment 532722 [details] [diff] [review]
Patch v1, adding input guards

Review of attachment 532722 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/html/content/src/nsTimeRanges.h
@@ +41,5 @@
>  #include "nsTArray.h"
>  
> +#if !defined(nsTimeRanges_h__)
> +#define nsTimeRanges_h__
> +

Please put this before the list of #include and use "ifndef" instead of "!defined".
Attachment #532722 - Flags: review?(chris) → review-
(Assignee)

Comment 3

6 years ago
Created attachment 532750 [details] [diff] [review]
Patch v1, adressing Mounir's concerns
Attachment #532722 - Attachment is obsolete: true
Attachment #532750 - Flags: review?(mounir.lamouri)
Comment on attachment 532750 [details] [diff] [review]
Patch v1, adressing Mounir's concerns

Review of attachment 532750 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/html/content/src/nsTimeRanges.h
@@ +37,5 @@
>   * ***** END LICENSE BLOCK ***** */
>  
> +#if !defined(nsTimeRanges_h__)
> +#define nsTimeRanges_h__
> +

Please, don't use !defined but ifndef instead.
Attachment #532750 - Flags: review?(mounir.lamouri) → review+
(Assignee)

Comment 5

6 years ago
Created attachment 532754 [details] [diff] [review]
Patch v3

I usually use #ifndef, but decided to be consistent with the other file of the module.

Anyway, here's the corrected version.
Attachment #532750 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Attachment #532754 - Flags: review?(mounir.lamouri)
Comment on attachment 532754 [details] [diff] [review]
Patch v3

Review of attachment 532754 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks :)
Attachment #532754 - Flags: review?(mounir.lamouri) → review+
Keywords: checkin-needed
http://hg.mozilla.org/projects/cedar/rev/92f83b5cded7
Keywords: checkin-needed
Whiteboard: [fixed in cedar]
Pushed:
http://hg.mozilla.org/mozilla-central/rev/92f83b5cded7
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [fixed in cedar]
Target Milestone: --- → mozilla6
You need to log in before you can comment on or make changes to this bug.