657447 - Missing include guards in nsTimeRange class

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Paul Adenot (:padenot)]

There is no include guards in this .h file.

Comment 1

[Paul Adenot (:padenot)]

Attachment: Patch v1, adding input guards

Comment 2

[Mounir Lamouri (:mounir)]

Comment on attachment 532722 [details] [diff] [review]
Patch v1, adding input guards

Review of attachment 532722 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/html/content/src/nsTimeRanges.h
@@ +41,5 @@
>  #include "nsTArray.h"
>  
> +#if !defined(nsTimeRanges_h__)
> +#define nsTimeRanges_h__
> +

Please put this before the list of #include and use "ifndef" instead of "!defined".

Comment 3

[Paul Adenot (:padenot)]

Attachment: Patch v1, adressing Mounir's concerns

Comment 4

[Mounir Lamouri (:mounir)]

Comment on attachment 532750 [details] [diff] [review]
Patch v1, adressing Mounir's concerns

Review of attachment 532750 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/html/content/src/nsTimeRanges.h
@@ +37,5 @@
>   * ***** END LICENSE BLOCK ***** */
>  
> +#if !defined(nsTimeRanges_h__)
> +#define nsTimeRanges_h__
> +

Please, don't use !defined but ifndef instead.

Comment 5

[Paul Adenot (:padenot)]

Attachment: Patch v3

I usually use #ifndef, but decided to be consistent with the other file of the module.

Anyway, here's the corrected version.

Comment 6

[Mounir Lamouri (:mounir)]

Comment on attachment 532754 [details] [diff] [review]
Patch v3

Review of attachment 532754 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks :)

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/projects/cedar/rev/92f83b5cded7

Comment 8

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/92f83b5cded7