Include static keyword in definitions of signal callback functions

RESOLVED FIXED in mozilla6

Status

()

Core
Widget: Gtk
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: hiro, Assigned: hiro)

Tracking

Trunk
mozilla6
All
Linux
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 532758 [details] [diff] [review]
A patch

I do not know why those functions are not static but I guess those were copy-and-paste from static method of nsWindow class.
(Assignee)

Updated

6 years ago
Attachment #532758 - Flags: review?(karlt)
Comment on attachment 532758 [details] [diff] [review]
A patch

AFAIK all of these methods already have internal linkage due to the static keyword in their declaration, but it makes sense to me to explicitly specify in the definition also.
Attachment #532758 - Flags: review?(karlt) → review+
Summary: Callback functions of signals shoud be static function → Include static keyword in definitions of signal callback functions
(Assignee)

Updated

6 years ago
Assignee: nobody → hiikezoe
Keywords: checkin-needed
Hiroyuki, when adding "checkin-needed" on a bug, could you make sure your patch is properly formatted so the push is easier to do. See these links: 
https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3f
http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed

And thanks for all these patches :)
Status: NEW → ASSIGNED
Keywords: checkin-needed
Whiteboard: [fixed in cedar]
Version: unspecified → Trunk
Pushed:
http://hg.mozilla.org/mozilla-central/rev/72dc5f89f9cd
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [fixed in cedar]
Target Milestone: --- → mozilla6
You need to log in before you can comment on or make changes to this bug.