657541 - Add functions to ScriptableObject that will introspect for annotations and define properties automatically

Status: RESOLVED INACTIVE

(Rhino Graveyard :: Core, enhancement)

Description

[Joshua Storck]

User-Agent:       Mozilla/5.0 (X11; Linux i686) AppleWebKit/534.24 (KHTML, like Gecko) Ubuntu/10.04 Chromium/11.0.696.65 Chrome/11.0.696.65 Safari/534.24
Build Identifier: 

While the ScriptableObject.defineClass method introspects methods with JSSetter, JSGetter, JSFunction, and JSStaticFunction annotations, there is no equivalent for the ScriptableObject.defineFunctionProperties and ScriptableObject.defineFunctionProperty(String, Class<?>, int). 

I propose adding two new methods to ScriptableObject:

void defineFunctionPropertiesFromAnnotations(Class<?>)
void definePropertiesFromAnnotations(Class<?>)

I have implemented the methods and have a patch ready including unit tests.

Reproducible: Always

Steps to Reproduce:
N/A

Comment 1

[Joshua Storck]

Attachment: Proposed implementation of the new feature

I have added a new annotation called JSAttributes. This annotation will be used instead of passing in an attributes parameter to the proposed methods

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Closing. Bug management is now done here:
https://github.com/mozilla/rhino