Last Comment Bug 657709 - Cleanup histogram API
: Cleanup histogram API
Product: Core
Classification: Components
Component: General (show other bugs)
: unspecified
: x86 Linux
-- normal (vote)
: ---
Assigned To: (dormant account)
Depends on: 649502
Blocks: 657297
  Show dependency treegraph
Reported: 2011-05-17 11:42 PDT by (dormant account)
Modified: 2011-05-19 19:34 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

cleanup (7.91 KB, patch)
2011-05-17 12:05 PDT, (dormant account)
no flags Details | Diff | Splinter Review
cleanup (10.79 KB, patch)
2011-05-18 17:27 PDT, (dormant account)
mrbkap: review+
Details | Diff | Splinter Review

Description User image (dormant account) 2011-05-17 11:42:19 PDT
Clean up histogram API to be more coherent by passing histogram type in as a parameter. Also rename C++ implementation filename and add a namespace.
Comment 1 User image (dormant account) 2011-05-17 12:05:46 PDT
Created attachment 533034 [details] [diff] [review]
Comment 2 User image Mike Hommey [:glandium] 2011-05-18 01:43:04 PDT
How about ?
Comment 3 User image Mike Hommey [:glandium] 2011-05-18 02:31:39 PDT
(In reply to comment #2)
> How about ?

Oh I didn't see this was (mostly) addressed in the patch. Why not the mozilla namespace?
Comment 4 User image (dormant account) 2011-05-18 13:08:26 PDT
(In reply to comment #3)
> (In reply to comment #2)
> > How about ?
> Oh I didn't see this was (mostly) addressed in the patch. Why not the
> mozilla namespace?

I don't see the benefit of it. The anonymous namespace allows better linking/optimization behavior. There is currently no need for the mozilla namespace, can be added later when there is something that uses or goes into it.
Comment 5 User image (dormant account) 2011-05-18 17:27:34 PDT
Created attachment 533479 [details] [diff] [review]

Minor update to previous patch:
* Removed toplevel static from Telemetry.cpp (made redundant by anonymous namespace)
* vesion -> version typo fix.
Comment 6 User image Blake Kaplan (:mrbkap) 2011-05-19 15:16:30 PDT
Comment on attachment 533479 [details] [diff] [review]

Review of attachment 533479 [details] [diff] [review]:
Comment 7 User image (dormant account) 2011-05-19 19:34:48 PDT

Note You need to log in before you can comment on or make changes to this bug.