65773 - [BiDi] Mozilla won't start on Arabic/Hewbrew MacOS

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect, P3)

Description

[Frank Tang]

This is seperate from bug 61031. The reason which crash CE is different from the
reason it crash Hebrew/Arabic
We currently do not have x-mac-hebrew/x-mac-arabic converter.

Comment 1

[nhottanscp]

Frank, is this a Macintosh specific issue, do we have converters for win32?

Comment 2

[nhottanscp]

Reassign to ftang.

Comment 3

[Frank Tang]

Mark it as moz0.9 P3

Comment 4

[timeless]

*** Bug 69277 has been marked as a duplicate of this bug. ***

Comment 5

[Teruko Kobayashi]

Changed QA contact to [e-mail].

Comment 6

[Frank Tang]

Attachment: patch

Comment 7

[Frank Tang]

It looks like this patch along does not solve the problem. We also crash in the
sorting code.

Probably we should produce a x-mac-hebrew, x-mac-arabic converters

Comment 8

[Frank Tang]

The first patch does not work. I have check in the converter source file w/o 
hookup to the build yet. 
Here is the file which need to be review
under mozilla/intl/uconv/ucvlatin

macarabic.uf
macarabic.ut
macdevanaga.uf
macdevanaga.ut
macfarsi.uf
macfarsi.ut
macgujarati.uf
macgujarati.ut
macgurmukhi.uf
macgurmukhi.ut
machebrew.uf
machebrew.ut
nsMacArabicToUnicode.cpp
nsMacArabicToUnicode.h
nsMacDevanagariToUnicode.cpp
nsMacDevanagariToUnicode.h
nsMacFarsiToUnicode.cpp
nsMacFarsiToUnicode.h
nsMacGujaratiToUnicode.cpp
nsMacGujaratiToUnicode.h
nsMacGurmukhiToUnicode.cpp
nsMacGurmukhiToUnicode.h
nsMacHebrewToUnicode.cpp
nsMacHebrewToUnicode.h
nsUnicodeToMacArabic.cpp
nsUnicodeToMacArabic.h
nsUnicodeToMacDevanagari.cpp
nsUnicodeToMacDevanagari.h
nsUnicodeToMacFarsi.cpp
nsUnicodeToMacFarsi.h
nsUnicodeToMacGujarati.cpp
nsUnicodeToMacGujarati.h
nsUnicodeToMacGurmukhi.cpp
nsUnicodeToMacGurmukhi.h
nsUnicodeToMacHebrew.cpp
nsUnicodeToMacHebrew.h

Also, the following patches

Comment 9

[Frank Tang]

Attachment: new patch part 1

Comment 10

[Frank Tang]

sorry, I submit the wrong file in the attachement. Do it again

Comment 11

[Frank Tang]

Attachment: real new patch - part 1

Comment 12

[Frank Tang]

Attachment: real new patch- part 2- unix make file

Comment 13

[Frank Tang]

hum... those *uf and *ut I check in is not good enough. I need to rework on that 
part. 

Comment 14

[Frank Tang]

Attachment: intl/uconv/ucvlatin/macarabic.uf

Comment 15

[Frank Tang]

Attachment: intl/uconv/ucvlatin/macarabic.ut

Comment 16

[Frank Tang]

Attachment: intl/uconv/ucvlatin/macdevanaga.uf

Comment 17

[Frank Tang]

Attachment: intl/uconv/ucvlatin/macdevanaga.ut

Comment 18

[Frank Tang]

Attachment: intl/uconv/ucvlatin/macfarsi.uf

Comment 19

[Frank Tang]

Attachment: intl/uconv/ucvlatin/macfarsi.ut

Comment 20

[Frank Tang]

Attachment: intl/uconv/ucvlatin/macgujarati.uf

Comment 21

[Frank Tang]

Attachment: intl/uconv/ucvlatin/macgujarati.ut

Comment 22

[Frank Tang]

Attachment: intl/uconv/ucvlatin/macgurmukhi.uf

Comment 23

[Frank Tang]

Attachment: intl/uconv/ucvlatin/macgurmukhi.ut

Comment 24

[Frank Tang]

Attachment: intl/uconv/ucvlatin/machebrew.uf

Comment 25

[Frank Tang]

Attachment: intl/uconv/ucvlatin/macarabic.ut

Comment 26

[Frank Tang]

ok- here is the fix
1. add the following file to ucvlatin.mcp :
+       nsMacArabicToUnicode.cpp        \
+       nsMacDevanagariToUnicode.cpp    \
+       nsMacGujaratiToUnicode.cpp      \
+       nsMacGurmukhiToUnicode.cpp      \
+       nsMacHebrewToUnicode.cpp        \
+       nsMacFarsiToUnicode.cpp         \
+       nsUnicodeToMacArabic.cpp        \
+       nsUnicodeToMacDevanagari.cpp    \
+       nsUnicodeToMacGujarati.cpp      \
+       nsUnicodeToMacGurmukhi.cpp      \
+       nsUnicodeToMacHebrew.cpp        \
+       nsUnicodeToMacFarsi.cpp         \
2. take the following patch
04/04/01 07:42
                                             real new patch - part 1   (text/
plain)
             04/04/01 07:42
                                             real new patch- part 2- unix make 
file   (text/plain)
             04/11/01 14:02
                                             intl/uconv/ucvlatin/macarabic.uf   
(text/plain)
             04/11/01 14:03
                                             intl/uconv/ucvlatin/macarabic.ut   
(text/plain)
             04/11/01 14:03
                                             intl/uconv/ucvlatin/macdevanaga.uf   
(text/plain)
             04/11/01 14:03
                                             intl/uconv/ucvlatin/macdevanaga.ut   
(text/plain)
             04/11/01 14:04
                                             intl/uconv/ucvlatin/macfarsi.uf   
(text/plain)
             04/11/01 14:04
                                             intl/uconv/ucvlatin/macfarsi.ut   
(text/plain)
             04/11/01 14:04
                                             intl/uconv/ucvlatin/macgujarati.uf   
(text/plain)
             04/11/01 14:05
                                             intl/uconv/ucvlatin/macgujarati.ut   
(text/plain)
             04/11/01 14:05
                                             intl/uconv/ucvlatin/macgurmukhi.uf   
(text/plain)
             04/11/01 14:06
                                             intl/uconv/ucvlatin/macgurmukhi.ut   
(text/plain)
             04/11/01 14:06
                                             intl/uconv/ucvlatin/machebrew.uf   
(text/plain)
             04/11/01 14:07
                                             intl/uconv/ucvlatin/macarabic.ut   
(text/plain)

Comment 27

[Simon Fraser [no longer active]]

What are .ut and .uf files? Do these autogenerate source files? I've never 
understood why we have any source files for trivial charset mappings, rather than 
simply using lookup tables.

Comment 28

[Frank Tang]

fix and check in . 

Comment 29

[Andreas Becker]

Changing component to BiDi and adding keyword intl.

Switching QA contact to [e-mail].