Closed Bug 658001 Opened 13 years ago Closed 13 years ago

need to clear mouse capture if the capturing frame is inside a hidden deck panel or hidden tab

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: tnikkel, Assigned: tnikkel)

References

Details

Attachments

(1 file, 1 obsolete file)

When a view is hidden it clears the mouse capture if it is in that view. I think we'll need to keep this behaviour. Just dropping mouse capture based on the IsActive of the docshell/presshell I don't think is enough because we have other decks (namely Panorama uses a deck above the tabbrowsers to hide/show the Panorama view).
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → tnikkel
Attachment #533348 - Flags: review?(roc)
Comment on attachment 533348 [details] [diff] [review]
patch

Review of attachment 533348 [details] [diff] [review]:
-----------------------------------------------------------------

Can you also rewrite ClearMouseCapture(nsIView*) so that it uses ClearMouseCapture(nsIFrame*)? E.g. I think you should be able to find the nearest view with a frame, then call ClearMouseCapture on that frame.
Attachment #533348 - Flags: review?(roc) → review+
Attached patch patch v2Splinter Review
Applied review comment.
Attachment #533348 - Attachment is obsolete: true
Attachment #569281 - Flags: review?(roc)
https://hg.mozilla.org/mozilla-central/rev/8c77d5a44c7c
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Depends on: 698266
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: