The default bug view has changed. See this FAQ.

need to clear mouse capture if the capturing frame is inside a hidden deck panel or hidden tab

RESOLVED FIXED in mozilla10

Status

()

Core
Layout
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: tnikkel, Assigned: tnikkel)

Tracking

Trunk
mozilla10
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
When a view is hidden it clears the mouse capture if it is in that view. I think we'll need to keep this behaviour. Just dropping mouse capture based on the IsActive of the docshell/presshell I don't think is enough because we have other decks (namely Panorama uses a deck above the tabbrowsers to hide/show the Panorama view).
(Assignee)

Comment 1

6 years ago
Created attachment 533348 [details] [diff] [review]
patch
Assignee: nobody → tnikkel
Attachment #533348 - Flags: review?(roc)
Comment on attachment 533348 [details] [diff] [review]
patch

Review of attachment 533348 [details] [diff] [review]:
-----------------------------------------------------------------

Can you also rewrite ClearMouseCapture(nsIView*) so that it uses ClearMouseCapture(nsIFrame*)? E.g. I think you should be able to find the nearest view with a frame, then call ClearMouseCapture on that frame.
Attachment #533348 - Flags: review?(roc) → review+
(Assignee)

Comment 3

6 years ago
Created attachment 569281 [details] [diff] [review]
patch v2

Applied review comment.
Attachment #533348 - Attachment is obsolete: true
Attachment #569281 - Flags: review?(roc)
Attachment #569281 - Flags: review?(roc) → review+
(Assignee)

Comment 4

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/8c77d5a44c7c
https://hg.mozilla.org/mozilla-central/rev/8c77d5a44c7c
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10

Updated

6 years ago
Depends on: 698266
You need to log in before you can comment on or make changes to this bug.