658024 - w32 builders spewing logs to stdout

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

In staging, I'm seeing the w32 builders failing to log to twistd.log.  The old buildbot.tac looks like

E:\builds\moz2_slave>type buildbot.tac
from twisted.application import service
from buildbot.slave.bot import BuildSlave

maxdelay = 300
buildmaster_host = 'production-master01.build.mozilla.org'
passwd = 'm0z1LLaTw0'
maxRotatedFiles = None
basedir = r'e:\builds\moz2_slave'
umask = 002
slavename = 'w32-ix-slave04'
usepty = 1
rotateLength = 1000000
port = 9010
keepalive = None

application = service.Application('buildslave')
try:
  from twisted.python.logfile import LogFile
  from twisted.python.log import ILogObserver, FileLogObserver
  logfile = LogFile.fromFullPath("twistd.log", rotateLength=rotateLength,
                                 maxRotatedFiles=maxRotatedFiles)
  application.setComponent(ILogObserver, FileLogObserver(logfile).emit)
except ImportError:
  # probably not yet twisted 8.2.0 and beyond, can't set log yet
  pass
s = BuildSlave(buildmaster_host, port, slavename, passwd, basedir,
               keepalive, usepty, umask=umask, maxdelay=maxdelay)
s.setServiceParent(application)

which is about the same as what slavealloc is handing out, so I'm not sure what the deal is.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: m658024-puppet-manifests-r1.patch

It's an ancient version of Twisted that doesn't log to a file by default on windows, apparently.  'buildbot start' adds teh --logfile parameter, and this seems to fix it ('course, you don't get log rotation..)

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

checked in and deployed via puppet - I'll upgrade the w32 back in bug 616351.