Closed
Bug 658087
Opened 14 years ago
Closed 12 years ago
Make TabChild be quiet
Categories
(Core :: IPC, defect)
Core
IPC
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: stechz, Assigned: evilpies)
References
Details
Attachments
(1 file, 2 obsolete files)
|
2.00 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
It's printfing all over the place!
|
Reporter | |
Comment 1•14 years ago
|
||
Attachment #533444 -
Flags: review?(Olli.Pettay)
|
|
Reporter | |
Comment 2•14 years ago
|
||
Compile issues on Windows
Attachment #533684 -
Flags: review?(Olli.Pettay)
|
|
Reporter | |
Updated•14 years ago
|
Attachment #533444 -
Attachment is obsolete: true
Attachment #533444 -
Flags: review?(Olli.Pettay)
|
||
Comment 3•14 years ago
|
||
Comment on attachment 533684 [details] [diff] [review]
Make TabChild be quiet
Is anyone going to use log which just prints "creating ..." and "loading..."?
Would it make sense to put those printfs just inside #ifdef DEBUG?
|
|
Reporter | |
Comment 4•14 years ago
|
||
I just want them hidden by default, debug and optimized. Perhaps remove them if they aren't useful to anyone?
|
|
||
Comment 5•14 years ago
|
||
Comment on attachment 533684 [details] [diff] [review]
Make TabChild be quiet
So unless there is some good use case for the log, I'd prefer
#ifdef DEBUG
Attachment #533684 -
Flags: review?(Olli.Pettay) → review-
|
|
Reporter | |
Comment 6•14 years ago
|
||
(In reply to comment #5)
> Comment on attachment 533684 [details] [diff] [review] [review]
> Make TabChild be quiet
>
> So unless there is some good use case for the log, I'd prefer
> #ifdef DEBUG
Again, I don't want these logs on debug builds either.
|
|
Reporter | |
Comment 7•14 years ago
|
||
At least, not enabled by default.
I can't imagine these printfs being useful to anyone anymore. Some of them were added for debugging purposes during the initial e10s sprint in 2009 ...
|
Assignee | |
Comment 9•12 years ago
|
||
I think now that we have e10s for thumbs we should really fix this logging in release builds.
Blocks: core-e10s
|
|
Assignee | |
Comment 10•12 years ago
|
||
I don't think these log message are helpful in any way, so we might as well remove them.
Assignee: nobody → evilpies
Attachment #533684 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #794127 -
Flags: review?(bugs)
|
|
||
Updated•12 years ago
|
Attachment #794127 -
Flags: review?(bugs) → review+
|
||
Comment 11•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•