Swap mozilla-aurora to gcc 4.5 when m-c merges there on May 24th

RESOLVED FIXED

Status

Release Engineering
Other
P3
normal
RESOLVED FIXED
6 years ago
3 years ago

People

(Reporter: nthomas, Assigned: armenzg)

Tracking

Firefox Tracking Flags

(firefox6+ affected)

Details

(Whiteboard: [mozconfig] nominated by armen at comment 3 see also comment 9)

Attachments

(1 attachment)

Comment hidden (empty)
(and again when merged to beta, and again when merged to release ; really, bug 558180 would make life easier)

Updated

6 years ago
Priority: -- → P3
Whiteboard: [mozconfig]
Duplicate of this bug: 659630
(Assignee)

Updated

6 years ago
Assignee: nobody → armenzg
Status: NEW → ASSIGNED
We forgot to track it for Firefox 6.
tracking-firefox6: --- → ?
Created attachment 535069 [details] [diff] [review]
[mozconfigs] merge from m-c to m-a

I did this:
* for each platform I cd into it and run this:
> rsync -r mozilla-central/* mozilla-aurora
* I added new files like this:
> for file in `hg st -un`; do hg add $file; done
* then I run this:
> for file in `find . -type f -name mozconfig | grep aurora`; do sed s/nightly/aurora/ < $file > $file.2; mv $file.2 $file; done

The last one fixes keeping the right update channel.
Attachment #535069 - Flags: review?(bhearsum)
Comment on attachment 535069 [details] [diff] [review]
[mozconfigs] merge from m-c to m-a

r+ for the mozilla2/ portions. The thunderbird/ bits look fine to me too, but you should get review from either gozer or Standard8 for them anyways.
Attachment #535069 - Flags: review?(mbanner)
Attachment #535069 - Flags: review?(gozer)
Attachment #535069 - Flags: review?(bhearsum)
Attachment #535069 - Flags: review+
Comment on attachment 535069 [details] [diff] [review]
[mozconfigs] merge from m-c to m-a

I landed the mozilla2/ part of it and left thunderbird out of it until reviews come in:
http://hg.mozilla.org/build/buildbot-configs/rev/3bcd07c94764
Attachment #535069 - Flags: review?(gozer) → review+
Attachment #535069 - Flags: review?(mbanner)
Comment on attachment 535069 [details] [diff] [review]
[mozconfigs] merge from m-c to m-a

Thanks for thinking about Thunderbird. There's actually a couple of things I need to check before we do turn on/switch to that channel, so if you don't mind, I'll handle this change in a follow-up bug once I've got the confirmation.

Thanks again.
Attachment #535069 - Flags: review+
standard8 all yours :)
I have marked bug 558180 to deal with tracking updating the mozconfigs forward on the next merge day.

There is nothing left to be done on this bug.

I checked that the mozconfig looked right on the nightly build.
Can any of you verify it?
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Reporter)

Comment 10

6 years ago
Mark, despite comment #8 the Thunderbird changes did land.
(In reply to comment #10)
> Mark, despite comment #8 the Thunderbird changes did land.

Ok, thanks, we'll survive :-)
(In reply to comment #10)
> Mark, despite comment #8 the Thunderbird changes did land.

Sorry :(

Updated

6 years ago
Whiteboard: [mozconfig] → [mozconfig] nominated by armen at comment 3 see also comment 9
asa what does the nomination imply?
That someone will check that Firefox 6 is compiled with gcc-4.5?

Updated

6 years ago
tracking-firefox6: ? → +

Updated

6 years ago
status-firefox6: --- → fixed
Mozilla/5.0 (X11; Linux x86_64; rv:6.0) Gecko/20100101 Firefox/6.0

Can this issue be set to verified fixed? Has the initial bug been fixed?
Unfortunately, the 6.0 builds off mozilla-release are not built with gcc 4.5 and PGO :(
status-firefox6: fixed → affected
(Reporter)

Comment 16

6 years ago
(In reply to Mike Hommey [:glandium] from comment #15)
> Unfortunately, the 6.0 builds off mozilla-release are not built with gcc 4.5
> and PGO :(

That's strange, because we updated the mozconfigs in bug 676083. And it looks like we used them in the linux32 log:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/6.0-candidates/build1/logs/release-mozilla-release-linux_build-build1.txt.gz

about:buildconfig also says gcc 4.5.2. Where do you see the issue ?
I saw the issue on http://tbpl.allizom.org/?tree=Mozilla-Release&usebuildbot=1
(In reply to Mike Hommey [:glandium] from comment #17)
> I saw the issue on
> http://tbpl.allizom.org/?tree=Mozilla-Release&usebuildbot=1

(that is, the build logs from there, and the talos results which are seriously regressed)
(Reporter)

Comment 19

6 years ago
Ah hah, that's because Rail only did the release/ dir, and not the others. Where do you want to fix that Rail ?
(Reporter)

Comment 20

6 years ago
BTW, those are builds on tbpl are triggered by the landings in the repo, rather than the actual release bits. We should still fix the configs though.
I filed bug 679638
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.