658213 - Use [implicit_jscontext] on document.open, delete cry for help in nsContentUtils::ReparentContentWrappersInScope

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[Jason Orendorff [:jorendorff]]

See bug 652818 comment 6 (and subsequent discussion).

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Just pass an JSContext to ReparentContentWrappersInScope.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Rebased over bug 659113

Because I was feeling nice

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Rebased over bug 659113

(This one should actually apply for you)

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Pass it along

Comment 5

[Peter Van der Beken [:peterv]]

Comment on attachment 535843 [details] [diff] [review]
Pass it along

Review of attachment 535843 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/html/document/src/nsHTMLDocument.cpp
@@ +1545,5 @@
>  
>  // XXX TBI: accepting arguments to the open method.
>  nsresult
> +nsHTMLDocument::OpenCommon(JSContext *cx, const nsACString& aContentType,
> +                           PRBool aReplace)

It looks like there is only one caller of OpenCommon, can we remove OpenCommon and make this nsHTMLDocument::Open?

::: dom/interfaces/html/nsIDOMHTMLDocument.idl
@@ +39,5 @@
>  
>  #include "nsIDOMDocument.idl"
>  
> +%{C++
> +#include "jsapi.h"

Would jspubtd.h be better?

Comment 6

[Josh Matthews [:jdm]]

http://hg.mozilla.org/mozilla-central/rev/f4273556fc42

Comment 7

[Boris Zbarsky [:bzbarsky]]

May I ask for a favor?  Please don't check in my patches that have pending unaddressed review comments on them?  :(

Comment 8

[Boris Zbarsky [:bzbarsky]]

And to be clear, if I want someone to push one of my patches I will _definitely_ add the checkin-needed keyword to the bug!

Comment 9

[Boris Zbarsky [:bzbarsky]]

Peter, I'll look into comment 5 tomorrow and probably land a followup...

Comment 10

[Peter Van der Beken [:peterv]]

Ms2ger told me he'd do the OpenCommon -> Open change in a followup (the jspubtd.h change got done already).