658282 - Previously checked radio button does not get the invalid style

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Anthony Ricaud (:rik)]

Attachment: Testcase

See instructions in the testcase.

Comment 1

[Anthony Ricaud (:rik)]

Also, I've only tested on my Mac. Might be a cross platform issue.

Comment 2

[Mounir Lamouri (:mounir)]

Thanks for the testcase.

Comment 3

[Boris Zbarsky [:bzbarsky]]

This worksforme in my build with the fix for bug 598833, fwiw.  The question is whether that's accidental...

Comment 4

[Mounir Lamouri (:mounir)]

I'm improving a part of my test suite for <input type='radio'> and I think I catch this issue by doing that...

Comment 5

[Mounir Lamouri (:mounir)]

Attachment: Part 1 - Improve css-invalid/input/ test suite

I need tests that check the actual rendering of radio buttons. I will probably have to open some follow-ups for all similar tests.

Comment 6

[Mounir Lamouri (:mounir)]

Attachment: Part 2 - Actual fix.

Actually, the patch is quite trivial: UpdateValueMissingValidityStateForRadio doesn't notify about |this| state change because callers have to worry about that... But one was not doing that.

Comment 7

[Mounir Lamouri (:mounir)]

BTW, there were a path for checkboxes and another for radio because the radio path was using a radio group visitor but now, UpdateAllValidityStates is going to call the correct method.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Ah, indeed.  The patch in bug 598833 had added an UpdateState() call there.  I guess I can remove it with this change (UpdateAllValidityStates already does UpdateState(aNotify)).

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 533689 [details] [diff] [review]
Part 1 - Improve css-invalid/input/ test suite

r=me

Comment 10

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/b63ff702f39d
http://hg.mozilla.org/mozilla-central/rev/fca12da605c4

Thank you Anthony for reporting this.

Comment 11

[Mounir Lamouri (:mounir)]

Follow-up for updating test suite in bug 658542.

Comment 12

[Simona Badau, Desktop QA]

Mozilla/5.0 (Windows NT 5.1; rv:6.0) Gecko/20100101 Firefox/6.0

Verified issue on Windows XP, Windows 7, Mac OS X 10.6 and Ubuntu using the attached test case in Comment 0.

Setting resolution to VERIFIED FIXED.