Use elmo-lib as a submodule in vendor-local

RESOLVED FIXED in 1.2

Status

Webtools
Elmo
P2
normal
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: stas, Assigned: stas)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
The advantages would be:

- we can easily add other non-compiled dependencies to vendor
- we don't risk that upstream changes to playdoh-lib break our code when we do 'git submodule update'
(Assignee)

Updated

7 years ago
Assignee: nobody → stas
Status: NEW → ASSIGNED
(Assignee)

Updated

7 years ago
Priority: -- → P2
(Assignee)

Comment 1

7 years ago
Here's another idea:

- leave playdoh-lib in vendor/
- add elmo-lib in vendor-local/ (which has precedence in manage.py)
(Assignee)

Comment 2

7 years ago
Created attachment 535239 [details] [diff] [review]
Add vendor-local, update update_site.py

Here a patch implementing the vendor-local approach.  I created https://github.com/mozilla/elmo-lib, too.

I edited the update_script.py script to entirely rely on --recursive.  I don't think it's a good think to do 'git pull' inside the vendor[-local] submodule manually, as that can pull in more recent commits than the one registered as the submodule.  That looks lke a playdoh bug to me.
Attachment #535239 - Flags: review?(peterbe)
(Assignee)

Updated

7 years ago
Blocks: 548298

Updated

7 years ago
Attachment #535239 - Flags: review?(peterbe) → review+
(Assignee)

Comment 3

7 years ago
Pushed: https://github.com/mozilla/elmo/commit/c588fe2174b4d644d202cf596fb41cadd226c0dd

Please pull with `git pull && git submodule update --init --recursive`
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.2
(Assignee)

Comment 4

7 years ago
Adjusting the summary to what has been done.
Summary: Use elmo-lib instead of playdoh-lib for vendor/ → Use elmo-lib as a submodule in vendor-local
You need to log in before you can comment on or make changes to this bug.