The advantages would be: - we can easily add other non-compiled dependencies to vendor - we don't risk that upstream changes to playdoh-lib break our code when we do 'git submodule update'
Here's another idea: - leave playdoh-lib in vendor/ - add elmo-lib in vendor-local/ (which has precedence in manage.py)
Created attachment 535239 [details] [diff] [review] Add vendor-local, update update_site.py Here a patch implementing the vendor-local approach. I created https://github.com/mozilla/elmo-lib, too. I edited the update_script.py script to entirely rely on --recursive. I don't think it's a good think to do 'git pull' inside the vendor[-local] submodule manually, as that can pull in more recent commits than the one registered as the submodule. That looks lke a playdoh bug to me.
Pushed: https://github.com/mozilla/elmo/commit/c588fe2174b4d644d202cf596fb41cadd226c0dd Please pull with `git pull && git submodule update --init --recursive`
Adjusting the summary to what has been done.