Closed Bug 658332 Opened 13 years ago Closed 13 years ago

Desktop fennec doesn't display pages anymore

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Firefox 6

People

(Reporter: fabrice, Assigned: roc)

Details

Pages are all gray, but the viewport size is ok. THumbnails are also rendered correctly.

This doesn't happen on android.

Bisecting leads to two potential changesets from bug 647560 (I had to skip a revision that was not even compiling):

Due to skipped revisions, the first bad revision could be any of:
changeset:   69697:3a0159680d70
user:        Robert O'Callahan <robert@ocallahan.org>
date:        Wed May 18 23:24:52 2011 +1200
summary:     Bug 647560. Create ApplyDoubleBuffering to recursively walk layer tree and implement double-buffering by setting mUseIntermediateSurface on ContainerLayers where necessary. r=tnikkel

changeset:   69698:5978755e9a6f
user:        Robert O'Callahan <robert@ocallahan.org>
date:        Wed May 18 23:24:52 2011 +1200
summary:     Bug 647560. Cache temporary backbuffer surfaces. r=karlt
Feel free to back out those patches if you think that's needed. I can't do it right now, I'm not supposed to be working...
Assignee: nobody → roc
I have back out the offending code in bug 647560
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You really need Tinderbox tests to catch bustage like this.
(In reply to comment #3)
> You really need Tinderbox tests to catch bustage like this.

We need to check into why the IPC reftests did not catch it.
Could you provide some steps to reproduce for this bug, please?
Anna, the STR are simply to load any web page, eg. http://mozilla.org

Result expected: page displayed

Result: the page is all gray, but is scrollable and the tab thumbnail is rendered correctly
VERIFIED FIXED on:

Build Id: Mozilla /5.0 (Android;Linux armv7l;rv:6.0a1) Gecko/20110523 Firefox/6.0a1 Fennec/6.0a1 

Device: HTC Desire Z (Android 2.2)
Status: RESOLVED → VERIFIED
I did a desktop Linux debug build of Fennec with changeset 36bca8bcdb19 ("Bug 647560. Remove unused MayHaveOverlappingOrTransparentLayers") and it seems to be fine.
(In reply to comment #9)
> This build works for me on a fresh profile:
> http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/2011-05-19-04-mozilla-
> central-linux/fennec-6.0a1.en-US.linux-i686.tar.bz2
> 
> Fabrice, does that build work for you?

The build works for me (it displays pages) but I see the crash reporter when trying to close it, not sure it is related though.
Could you reproduce this bug before?
(In reply to comment #11)
> Could you reproduce this bug before?

yes, I have even done the backout :)
Which build were you using to reproduce the bug? It seems to me that the build in comment #9 would have had the changesets that you backed out?
(In reply to comment #13)
> Which build were you using to reproduce the bug? It seems to me that the
> build in comment #9 would have had the changesets that you backed out?

about:buildconfig told me the build has been built against changeset http://hg.mozilla.org/mozilla-central/rev/4fd08a1e0644 that seems to be a few changesets before yours if I trust the shortlog: http://hg.mozilla.org/mozilla-central/shortlog/0bbb1318a394
Alright, I'll try that changeset at home.

It would also be helpful if you can give me a link to a specific nightly build download that fails for you that I can try. A debug build if possible. Thanks!
4fd08a1e0644 works fine for me as well.

It would be great if you can give me a link to a Tinderbox build that doesn't work for you.
(In reply to comment #16)
> 4fd08a1e0644 works fine for me as well.
> 
> It would be great if you can give me a link to a Tinderbox build that
> doesn't work for you.

Sorry I have been unclear, the build you have linked to in #c9 is build against changeset 4fd08a1e0644 and so it works fine since the code from bug 647560 is not there.
I will do a debug build with the bad changeset for you.
(In reply to comment #17)
> (In reply to comment #16)
> > 4fd08a1e0644 works fine for me as well.
> > 
> > It would be great if you can give me a link to a Tinderbox build that
> > doesn't work for you.
> 
> Sorry I have been unclear, the build you have linked to in #c9 is build
> against changeset 4fd08a1e0644 and so it works fine since the code from bug
> 647560 is not there.
> I will do a debug build with the bad changeset for you.

I have done a debug build with that you can found here: http://vingtetun.org/tmp/36bca8bcdb19-fennec-6.0a1.en-US.linux-x86_64.tar.bz2
Yay, I see the bug now! Thanks.

I don't know why my previous build with changeset 36bca8bcdb19 worked. I just did another build with that changeset and it doesn't work.
Target Milestone: --- → Firefox 6
So fennec-desktop-x11 was broken but fennec-android was OK?  Rob, what did you fix in bug 647560?  Is it possible to reftest or is it a widgety thing?
This patch fixed it:
https://bugzilla.mozilla.org/attachment.cgi?id=535977

I don't think we can reftest our double-buffering logic :-(.
You need to log in before you can comment on or make changes to this bug.