MOVE DEFINES FOR DOUBLE CONSTANTS OUT OF XSLT

RESOLVED FIXED

Status

()

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: tbsaunde, Assigned: tbsaunde)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

8 years ago
User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:6.0a1) Gecko/20110518 Firefox/6.0a1
Build Identifier: 

XSLT has some defines for doubles that would be useful outside of xslt

Reproducible: Always
(Assignee)

Updated

8 years ago
Whiteboard: :SICKING
(Assignee)

Comment 1

8 years ago
Created attachment 533763 [details] [diff] [review]
patch

first shot, there's a lot more random basic runtimey code in xslt/src/base that should go away eventually, but this atleast makes it smaller.
Attachment #533763 - Flags: review?(jonas)
Comment on attachment 533763 [details] [diff] [review]
patch

Looks good to me!
Attachment #533763 - Flags: review?(jonas) → review+
(Assignee)

Comment 3

8 years ago
landed on mozilla-central hg.mozilla.org/mozilla-central/rev/2b53d3079c78
/TMP/LINK
Assignee: nobody → trev.saunders
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Fwiw, it looks there's a typo in the commit, line 56 of txDouble.cpp there's still a 'txdpun' type used, and this broke builds on at least OpenBSD/sparc64, as can be seen on http://buildbot.rhaalovely.net/builders/comm-central-sparc64/builds/25/steps/build/logs/stdio

/var/buildslave/comm-central-sparc64/build/mozilla/content/xslt/src/base/txDouble.cpp:56: error: 'txdpun' does not name a type
/var/buildslave/comm-central-sparc64/build/mozilla/content/xslt/src/base/txDouble.cpp:56: error: extra ';'

I guess s/txdpun/dpun/ fixes it, will test. Reopening in the meantime.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Created attachment 536163 [details] [diff] [review]
Fix probable typo

Here's the hg patch i'm testing
(Assignee)

Comment 6

8 years ago
(In reply to comment #5)
> Created attachment 536163 [details] [diff] [review] [review]
> Fix probable typo
> 
> Here's the hg patch i'm testing

yeah, looks like  I missed a spot when I grepped for uses, sorry about that.
The patch fixes the build for me. (well, make package still chokes with bus error on sparc64, but that's another story)
(Assignee)

Updated

8 years ago
Status: REOPENED → RESOLVED
Last Resolved: 8 years ago8 years ago
Resolution: --- → FIXED

Updated

8 years ago
Whiteboard: :SICKING
You need to log in before you can comment on or make changes to this bug.