658425 - Move special-casing for passwords to the Site object

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[:Margaret Leibovic]

Password permissions are handled by the login manager, while other permissions are handled by the permission manager. Right now we special-case passwords in updatePermissions and onPermissionCommand in the AboutPermissions object, but it might be cleaner to handle it directly in the Site object.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

untested, for the moment!

Comment 2

[:Margaret Leibovic]

Comment on attachment 534462 [details] [diff] [review]
patch

This looks good to me. I tested it manually, and it works as expected. The tests in brower_permissions.js also pass.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/dd6b9fe6eea6

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Jorge: why did you add dev-doc-needed? This is an about:permissions implementation detail that shouldn't really matter to anyone else...

Comment 5

[Jorge Villalobos [:jorgev] (he/him)]

Shouldn't the Site object be documented somewhere so that extensions can use it?

Comment 6

[:Gavin Sharp [email: [e-mail]]]

No - it's not relevant to anything outside of about:permissions code (it isn't globally usable).