Move special-casing for passwords to the Site object

RESOLVED FIXED in Firefox 7

Status

()

Firefox
Preferences
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Margaret, Assigned: Gavin)

Tracking

Trunk
Firefox 7
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Password permissions are handled by the login manager, while other permissions are handled by the permission manager. Right now we special-case passwords in updatePermissions and onPermissionCommand in the AboutPermissions object, but it might be cleaner to handle it directly in the Site object.
Created attachment 534462 [details] [diff] [review]
patch

untested, for the moment!
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #534462 - Flags: feedback?
(Reporter)

Comment 2

6 years ago
Comment on attachment 534462 [details] [diff] [review]
patch

This looks good to me. I tested it manually, and it works as expected. The tests in brower_permissions.js also pass.
Attachment #534462 - Flags: feedback? → feedback+
(Reporter)

Updated

6 years ago
Attachment #534462 - Flags: review+
http://hg.mozilla.org/mozilla-central/rev/dd6b9fe6eea6
Flags: in-testsuite-
Target Milestone: --- → Firefox 7
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Keywords: dev-doc-needed
Jorge: why did you add dev-doc-needed? This is an about:permissions implementation detail that shouldn't really matter to anyone else...
Shouldn't the Site object be documented somewhere so that extensions can use it?
No - it's not relevant to anything outside of about:permissions code (it isn't globally usable).
Keywords: dev-doc-needed
You need to log in before you can comment on or make changes to this bug.