Last Comment Bug 658425 - Move special-casing for passwords to the Site object
: Move special-casing for passwords to the Site object
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Preferences (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Firefox 7
Assigned To: :Gavin Sharp [email: gavin@gavinsharp.com]
:
Mentors:
Depends on:
Blocks: 573176
  Show dependency treegraph
 
Reported: 2011-05-19 16:55 PDT by :Margaret Leibovic
Modified: 2011-06-21 08:02 PDT (History)
3 users (show)
gavin.sharp: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (4.20 KB, patch)
2011-05-23 09:55 PDT, :Gavin Sharp [email: gavin@gavinsharp.com]
margaret.leibovic: review+
margaret.leibovic: feedback+
Details | Diff | Review

Description :Margaret Leibovic 2011-05-19 16:55:50 PDT
Password permissions are handled by the login manager, while other permissions are handled by the permission manager. Right now we special-case passwords in updatePermissions and onPermissionCommand in the AboutPermissions object, but it might be cleaner to handle it directly in the Site object.
Comment 1 :Gavin Sharp [email: gavin@gavinsharp.com] 2011-05-23 09:55:02 PDT
Created attachment 534462 [details] [diff] [review]
patch

untested, for the moment!
Comment 2 :Margaret Leibovic 2011-05-23 12:31:23 PDT
Comment on attachment 534462 [details] [diff] [review]
patch

This looks good to me. I tested it manually, and it works as expected. The tests in brower_permissions.js also pass.
Comment 3 :Gavin Sharp [email: gavin@gavinsharp.com] 2011-06-03 10:25:28 PDT
http://hg.mozilla.org/mozilla-central/rev/dd6b9fe6eea6
Comment 4 :Gavin Sharp [email: gavin@gavinsharp.com] 2011-06-21 07:15:30 PDT
Jorge: why did you add dev-doc-needed? This is an about:permissions implementation detail that shouldn't really matter to anyone else...
Comment 5 Jorge Villalobos [:jorgev] 2011-06-21 07:57:35 PDT
Shouldn't the Site object be documented somewhere so that extensions can use it?
Comment 6 :Gavin Sharp [email: gavin@gavinsharp.com] 2011-06-21 08:02:17 PDT
No - it's not relevant to anything outside of about:permissions code (it isn't globally usable).

Note You need to log in before you can comment on or make changes to this bug.