Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Add loop hints to IonMonkey basic blocks for register allocation

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: adrake, Assigned: adrake)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

6 years ago
The linear scan liveness analysis requires knowledge of loop headers and, for optimization purposes, loop blocks and their respective depths themselves. These hints can be efficiently provided by IonMonkey during SSA construction.
(Assignee)

Comment 1

6 years ago
Created attachment 534040 [details] [diff] [review]
Trivial addition of loop header information (v0)

This adds a hint to the loop header as to the location of the end of the loop, which is needed for linear liveness analysis.
(Assignee)

Comment 2

6 years ago
Created attachment 534043 [details] [diff] [review]
Trivial addition of loop header information (v0)
Attachment #534040 - Attachment is obsolete: true
(Assignee)

Comment 3

6 years ago
Created attachment 534717 [details] [diff] [review]
Patch v1

Rebased, should be good to land on top of bug 659241 .
Attachment #534043 - Attachment is obsolete: true
Attachment #534717 - Flags: review?(dvander)
(Assignee)

Updated

6 years ago
Depends on: 659241
Attachment #534717 - Flags: review?(dvander) → review+
(Assignee)

Comment 4

6 years ago
http://hg.mozilla.org/users/danderson_mozilla.com/ionmonkey/rev/2f5a6b9e7a54
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.