Last Comment Bug 658486 - Add loop hints to IonMonkey basic blocks for register allocation
: Add loop hints to IonMonkey basic blocks for register allocation
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: ---
Assigned To: Andrew Drake [:adrake]
:
Mentors:
Depends on: 659241
Blocks: 657816
  Show dependency treegraph
 
Reported: 2011-05-20 01:43 PDT by Andrew Drake [:adrake]
Modified: 2011-05-24 21:18 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Trivial addition of loop header information (v0) (1.21 KB, patch)
2011-05-20 11:39 PDT, Andrew Drake [:adrake]
no flags Details | Diff | Review
Trivial addition of loop header information (v0) (1.37 KB, patch)
2011-05-20 11:51 PDT, Andrew Drake [:adrake]
no flags Details | Diff | Review
Patch v1 (2.09 KB, patch)
2011-05-24 04:02 PDT, Andrew Drake [:adrake]
dvander: review+
Details | Diff | Review

Description Andrew Drake [:adrake] 2011-05-20 01:43:45 PDT
The linear scan liveness analysis requires knowledge of loop headers and, for optimization purposes, loop blocks and their respective depths themselves. These hints can be efficiently provided by IonMonkey during SSA construction.
Comment 1 Andrew Drake [:adrake] 2011-05-20 11:39:54 PDT
Created attachment 534040 [details] [diff] [review]
Trivial addition of loop header information (v0)

This adds a hint to the loop header as to the location of the end of the loop, which is needed for linear liveness analysis.
Comment 2 Andrew Drake [:adrake] 2011-05-20 11:51:57 PDT
Created attachment 534043 [details] [diff] [review]
Trivial addition of loop header information (v0)
Comment 3 Andrew Drake [:adrake] 2011-05-24 04:02:38 PDT
Created attachment 534717 [details] [diff] [review]
Patch v1

Rebased, should be good to land on top of bug 659241 .

Note You need to log in before you can comment on or make changes to this bug.