Closed Bug 658494 Opened 9 years ago Closed 9 years ago

Build warnings for out-of-order init list in nsAccTreeWalker.cpp

Categories

(Core :: Disability Access APIs, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla6

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

(Whiteboard: [build_warning])

Attachments

(1 file)

Filing bug on this build warning:
{
/mozilla/accessible/src/base/nsAccTreeWalker.h:99:14: warning: ‘nsAccTreeWalker::mState’ will be initialized after
/mozilla/accessible/src/base/nsAccTreeWalker.h:98:8: warning:   ‘bool nsAccTreeWalker::mWalkCache’
/mozilla/accessible/src/base/nsAccTreeWalker.cpp:67:1: warning:   when initialized here
}
Attached patch trivial fixSplinter Review
This patch flips mWalkCache and mState in the init list, to match the ordering in the header file:
> 98   bool mWalkCache;
> 99   WalkState* mState;
http://mxr.mozilla.org/mozilla-central/source/accessible/src/base/nsAccTreeWalker.h#98
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #533921 - Flags: review?(bolterbugz)
Comment on attachment 533921 [details] [diff] [review]
trivial fix

Review of attachment 533921 [details] [diff] [review]:
-----------------------------------------------------------------

Taking over this review since davidb's AFK for today and Monday, and after talking to Dholbert on IRC. r=me, thanks!
Attachment #533921 - Flags: review?(bolterbugz) → review+
http://hg.mozilla.org/projects/cedar/rev/7bffd92f4825
Whiteboard: [build_warning] → [build_warning][fixed-in-cedar]
Pushed:
http://hg.mozilla.org/mozilla-central/rev/7bffd92f4825
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [build_warning][fixed-in-cedar] → [build_warning]
Target Milestone: --- → mozilla6
You need to log in before you can comment on or make changes to this bug.