removal of thread synchronization when setting a prototype

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Igor Bukanov, Assigned: Igor Bukanov)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Currently we still use the GC machinery to get an exclusive access to the prototype chain when setting a prototype. I suggest to remove that. The only drawback AFAICS is that it would be not possible to implement a thread-shared object with script-mutable prototype. But given the current plans it is rather unlikely that we would need to support such object.
(Assignee)

Comment 1

6 years ago
Created attachment 533953 [details] [diff] [review]
v1

Straightforward implementation
Assignee: general → igor
Attachment #533953 - Flags: review?(jorendorff)
Comment on attachment 533953 [details] [diff] [review]
v1

Looks perfect. Thanks.
Attachment #533953 - Flags: review?(jorendorff) → review+
(Assignee)

Comment 3

6 years ago
http://hg.mozilla.org/tracemonkey/rev/dbe681ddbd5b
Whiteboard: fixed-in-tracemonkey
cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/dbe681ddbd5b
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.