Last Comment Bug 658505 - removal of thread synchronization when setting a prototype
: removal of thread synchronization when setting a prototype
Status: RESOLVED FIXED
fixed-in-tracemonkey
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: x86_64 Linux
: -- normal (vote)
: ---
Assigned To: Igor Bukanov
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-05-20 04:24 PDT by Igor Bukanov
Modified: 2011-05-23 14:15 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v1 (3.98 KB, patch)
2011-05-20 06:50 PDT, Igor Bukanov
jorendorff: review+
Details | Diff | Review

Description Igor Bukanov 2011-05-20 04:24:28 PDT
Currently we still use the GC machinery to get an exclusive access to the prototype chain when setting a prototype. I suggest to remove that. The only drawback AFAICS is that it would be not possible to implement a thread-shared object with script-mutable prototype. But given the current plans it is rather unlikely that we would need to support such object.
Comment 1 Igor Bukanov 2011-05-20 06:50:34 PDT
Created attachment 533953 [details] [diff] [review]
v1

Straightforward implementation
Comment 2 Jason Orendorff [:jorendorff] 2011-05-20 09:25:03 PDT
Comment on attachment 533953 [details] [diff] [review]
v1

Looks perfect. Thanks.
Comment 4 Chris Leary [:cdleary] (not checking bugmail) 2011-05-23 14:15:35 PDT
cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/dbe681ddbd5b

Note You need to log in before you can comment on or make changes to this bug.