658516 - nsHTMLEditRules.cpp:5810:52: warning: comparison between signed and unsigned integer expressions

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[Daniel Holbert [:dholbert]]

Filing bug on this warning:
editor/libeditor/html/nsHTMLEditRules.cpp:5810:52: warning: comparison between signed and unsigned integer expressions

Flagged code is:
>   NS_ASSERTION(rangeCount == rangeItemArray.Length(), "How did that happen?");
where rangeCount is a signed int.

The contextual code already assumes it's non-negative[1], so it should be fine to just cast it to an unsigned value here.

[1] At this point in the code, we've just called  rangeItemArray.AppendElements(rangeCount), which would fail horribly if rangeCount were negative.
http://mxr.mozilla.org/mozilla-central/source/editor/libeditor/html/nsHTMLEditRules.cpp#5806

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 534119 [details] [diff] [review]
Patch (v1)

Review of attachment 534119 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 3

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/3fa9d9b92de8

Comment 4

[Trif Andrei-Alin[:AlinT]]

Is this issue fixed?
Thanks.

Comment 5

[Daniel Holbert [:dholbert]]

Yes. (link to patched chunk of source: http://mxr.mozilla.org/mozilla-central/source/editor/libeditor/html/nsHTMLEditRules.cpp?mark=5848-5849#5848 )