658541 - Generalize some more hard coded Tinderbox URLs

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Markus Stange [:mstange]]

Attachment: patch

Strictly speaking the AddCommentUI._submitURL removal belongs in bug 601743,
but meh

Comment 1

[Arpad Borsos [:Swatinem]]

Comment on attachment 533982 [details] [diff] [review]
patch

Review of attachment 533982 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/AddCommentUI.js
@@ -12,3 @@
>  
>    init: function AddCommentUI_init(submitURL) {
> -    this._submitURL = submitURL;

That var is still used: http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/file/8c1153a543a5/js/AddCommentUI.js#l329
I don’t see it replaced in this patch!

Comment 2

[Arpad Borsos [:Swatinem]]

Comment on attachment 533982 [details] [diff] [review]
patch

Review of attachment 533982 [details] [diff] [review]:
-----------------------------------------------------------------

Oh sorry I wasn’t paying too much attention on your comment. Of course, on top of that patch, it is unused, right!

Comment 3

[Markus Stange [:mstange]]

Comment on attachment 533982 [details] [diff] [review]
patch

Review of attachment 533982 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/AddCommentUI.js
@@ +98,5 @@
>          bugsSubmitData[suggestion.id] = {
>            header: suggestion.signature,
>            log: suggestion.log,
>            email: email.replace("@", "%"),
> +          logLink: machineResult.briefLogURL

Note to self: do something to make sure that this is an absolute URL

Comment 4

[Markus Stange [:mstange]]

Attachment: v2

This adds absoluteBaseURL and absoluteBriefLogURL.

Comment 5

[Arpad Borsos [:Swatinem]]

Comment on attachment 536564 [details] [diff] [review]
v2

Review of attachment 536564 [details] [diff] [review]:
-----------------------------------------------------------------