658554 - Undoing a tab pointing to about:blank does nothing

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Steps to reproduce:
 * open a new tab by tapping the bottom left "New Tab" button
 * dismiss the awesomescree
 * Close the tab by tapping the red cross arrow next to the tab thumbnail
 * Observe the tab in the "undo" box
 * once you have observed it enought, tap on it to re-open it

Actual result:
 * the "undo" tab dissapear and nothing else happen

Expected result:
 * There is 2 options, the first one is that we re-open about blank, but I think this doesn't make sense to do that since the new tab button is just below. So instead I think we should not move the about:blank tab to the "undo" box

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 533994 [details] [diff] [review]
Patch

seems good to me

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mozilla-central/rev/ce19ede6e34e

Comment 3

[Anna (Waverley)]

VERIFIED FIXED on:

Build ID: Mozilla /5.0 (Android;Linux armv7l;rv:7.0a1) Gecko/20110525 Firefox/7.0a1 Fennec/7.0a1 

Device: HTC Desire Z (Android 2.2)

Comment 4

[Dão Gottwald [:dao]]

bugspam