Closed Bug 658560 Opened 13 years ago Closed 11 years ago

Fix identity problem with CrossOriginWrappers

Categories

(Core :: XPConnect, defect)

Product:
Core
Component:
XPConnect
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: mrbkap, Assigned: mrbkap)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

Fix + test
5.41 KB, patch
mrbkap
: review+
Details | Diff | Splinter Review 
In the process of writing his JetPack wrappers, Alexandre has been finding a bunch of wrapper bugs (he tells me that he'll file more bugs when he has a chance). One bug that he found and that we debugged yesterday had to do with wrapper identity. Sticking an object as a property of a CrossOriginWrapper and immediately retrieving it would return an object not === to the original. I debugged this today (I'll attach a patch in a second).
Summary: Fix identity problem with CrossOirginWrappers → Fix identity problem with CrossOriginWrappers
Attached patch Fix + test — — Splinter Review 
The test is embarrassingly simple.
Attachment #534017 - Flags: review?(gal)
The bug I was working on is bug 601295.
Is there an easy way to get a win32 build to test the fix?
Comment on attachment 534017 [details] [diff] [review]
Fix + test

r=gal over my shoulder.
Attachment #534017 - Flags: review?(gal) → review+
http://hg.mozilla.org/tracemonkey/rev/18bfc77155aa

Alexandre, you should be able to grab an hourly build of tracemonkey once my push has cycled on Windows.
Whiteboard: fixed-in-tracemonkey
This was fixed a while ago... http://hg.mozilla.org/mozilla-central/rev/18bfc77155aa
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.