Closed
Bug 658704
Opened 14 years ago
Closed 13 years ago
widget/src/gtk2 should use new pref utilities
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
FIXED
mozilla7
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
Attachments
(1 file, 1 obsolete file)
|
22.31 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
Followup bug for bug 656826.
We should land this for Fx7 due to risk management.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #534153 -
Attachment is obsolete: true
Attachment #535314 -
Flags: review?(roc)
Comment on attachment 535314 [details] [diff] [review]
Patch v1.1
Review of attachment 535314 [details] [diff] [review]:
-----------------------------------------------------------------
::: widget/src/gtk2/nsPSPrinters.cpp
@@ +127,5 @@
> NS_LITERAL_CSTRING(NS_POSTSCRIPT_DRIVER_NAME "default"));
>
> + nsCAutoString list(PR_GetEnv("MOZILLA_POSTSCRIPT_PRINTER_LIST"));
> + if (list.IsEmpty()) {
> + Preferences::GetChar("print.printer_list", &list);
Use GetString with a direct return
Attachment #535314 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
You need to log in
before you can comment on or make changes to this bug.
Description
•