widget/src/gtk2 should use new pref utilities

RESOLVED FIXED in mozilla7

Status

()

Core
Widget: Gtk
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

Trunk
mozilla7
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 534153 [details] [diff] [review]
Patch v1.0

Followup bug for bug 656826.

We should land this for Fx7 due to risk management.
Created attachment 535314 [details] [diff] [review]
Patch v1.1
Attachment #534153 - Attachment is obsolete: true
Attachment #535314 - Flags: review?(roc)
Comment on attachment 535314 [details] [diff] [review]
Patch v1.1

Review of attachment 535314 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/src/gtk2/nsPSPrinters.cpp
@@ +127,5 @@
>              NS_LITERAL_CSTRING(NS_POSTSCRIPT_DRIVER_NAME "default"));
>  
> +    nsCAutoString list(PR_GetEnv("MOZILLA_POSTSCRIPT_PRINTER_LIST"));
> +    if (list.IsEmpty()) {
> +        Preferences::GetChar("print.printer_list", &list);

Use GetString with a direct return
Attachment #535314 - Flags: review?(roc) → review+
http://hg.mozilla.org/mozilla-central/rev/4ea52c0bd5be
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7

Comment 4

6 years ago
Hi guys. How can this be tested?
thanks
You need to log in before you can comment on or make changes to this bug.