658725 - NS_EXTERNALSHARINGAPPSERVICE_CID value is wrong and fail to compile

Status: VERIFIED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Oleg Romashin (:romaxa)]

Attachment: Compile fix

http://hg.mozilla.org/mozilla-central/rev/5176c8f2691e#l6.50
    6.48 +#define NS_EXTERNALSHARINGAPPSERVICE_CID \
    6.49 +  {0xea782c90, 0xc6ec, 0x11df, \
    6.50 +  {0xbd3, 0x08, 0x00, 0x20, 0x0c, 0x9a, 0x66, 0x74}}
                ^ - this is wrong

Comment 1

[Doug Turner (:dougt)]

How did this ever work?  when I reviewed Tero's patch, i assumed that it had basic testing.

Comment 3

[Oleg Romashin (:romaxa)]

I guess it did work before somehow by ignoring wrong value with compile warning...

Comment 4

[Boris Zbarsky [:bzbarsky]]

Can you _please_ add metadata to things you want others to push for you?  :(

Comment 5

[Doug Turner (:dougt)]

good idea.  might start requiring that on patches.  also, bzimport looks like it barfed on this patch:

hg qimport bz://658725

and

hg out

changeset:   70002:8e53a8d44a83
tag:         658725
tag:         qtip
tag:         tip
user:        Oleg Romashin <romaxa>
date:        Fri May 20 18:07:00 2011 -0700
summary:     imported patch 658725

Comment 6

[Boris Zbarsky [:bzbarsky]]

Fwiw, I did push this to cedar: http://hg.mozilla.org/projects/cedar/rev/10bfe807438c

But yes, patches with no commit info from someone who should know better should just get r-.

Comment 7

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/mozilla-central/rev/10bfe807438c

Comment 8

[Mihaela Velimiroviciu (:mihaelav)]

Can anyone please provide some guidelines that I can use to verify this fix? Do I need to create any specific environment to test it?

Thanks!

Comment 9

[Mihaela Velimiroviciu (:mihaelav)]

Verified the file uriloader/exthandler/unix/nsExternalSharingAppService.h in mozilla-central and changes mentioned in comment 7 are submitted. 

Changing resolution to VERIFIED-FIXED