NS_EXTERNALSHARINGAPPSERVICE_CID value is wrong and fail to compile

VERIFIED FIXED in mozilla7

Status

Core Graveyard
File Handling
VERIFIED FIXED
6 years ago
a year ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

Trunk
mozilla7
x86
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 534177 [details] [diff] [review]
Compile fix

http://hg.mozilla.org/mozilla-central/rev/5176c8f2691e#l6.50
    6.48 +#define NS_EXTERNALSHARINGAPPSERVICE_CID \
    6.49 +  {0xea782c90, 0xc6ec, 0x11df, \
    6.50 +  {0xbd3, 0x08, 0x00, 0x20, 0x0c, 0x9a, 0x66, 0x74}}
                ^ - this is wrong
Attachment #534177 - Flags: review?(doug.turner)

Comment 1

6 years ago
How did this ever work?  when I reviewed Tero's patch, i assumed that it had basic testing.

Updated

6 years ago
Duplicate of this bug: 658955
(Assignee)

Comment 3

6 years ago
I guess it did work before somehow by ignoring wrong value with compile warning...

Updated

6 years ago
Attachment #534177 - Flags: review?(doug.turner) → review+

Updated

6 years ago
Keywords: checkin-needed

Updated

6 years ago
Assignee: nobody → doug.turner
Can you _please_ add metadata to things you want others to push for you?  :(
Assignee: doug.turner → romaxa

Comment 5

6 years ago
good idea.  might start requiring that on patches.  also, bzimport looks like it barfed on this patch:

hg qimport bz://658725

and

hg out

changeset:   70002:8e53a8d44a83
tag:         658725
tag:         qtip
tag:         tip
user:        Oleg Romashin <romaxa>
date:        Fri May 20 18:07:00 2011 -0700
summary:     imported patch 658725
Fwiw, I did push this to cedar: http://hg.mozilla.org/projects/cedar/rev/10bfe807438c

But yes, patches with no commit info from someone who should know better should just get r-.
Keywords: checkin-needed
Whiteboard: fixed-in-cedar
http://hg.mozilla.org/mozilla-central/rev/10bfe807438c
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
Target Milestone: --- → mozilla7
Can anyone please provide some guidelines that I can use to verify this fix? Do I need to create any specific environment to test it?

Thanks!
Verified the file uriloader/exthandler/unix/nsExternalSharingAppService.h in mozilla-central and changes mentioned in comment 7 are submitted. 

Changing resolution to VERIFIED-FIXED
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.