658745 - Intermittent browser-chrome leak of 1 nsCacheEntry and 1 nsStringBuffer

Status: RESOLVED WORKSFORME

(Firefox :: General, defect)

Description

[Phil Ringnalda (:philor)]

Calling this front-end rather than netwerk because bz took a peek at the log, and was flabbergasted by how something browserly was hanging onto things so we would up with 500-odd domwindows to get rid of at shutdown, including apparently the one that was still desperately clinging to this nsCacheEntry

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1305941364.1305945463.28696.gz&fulltext=1
Rev3 WINNT 5.1 mozilla-central debug test mochitest-other on 2011/05/20 18:29:24
s: talos-r3-xp-013

(toward the start of the shutdown spew)
--DOCSHELL 07CFEBF8 == 11
--DOCSHELL 033C9D10 == 10
WARNING: DeactivateEntry: unable to bind active entry
: file e:/builds/moz2_slave/cen-w32-dbg/build/netwerk/cache/nsCacheService.cpp, line 2264
--DOCSHELL 03C361F0 == 9
--DOCSHELL 19B5F098 == 8
--DOCSHELL 037D8B90 == 7
--DOCSHELL 23833698 == 6
--DOCSHELL 235F9388 == 5
--DOCSHELL 2277BD40 == 4
--DOCSHELL 2316C4E0 == 3
--DOCSHELL 23720630 == 2
--DOMWINDOW == 528 (18121E78) [serial = 5997] [outer = 2143C460] [url = about:blank]
...
TEST-UNEXPECTED-FAIL | automationutils.processLeakLog() | leaked 104 bytes during test execution
TEST-UNEXPECTED-FAIL | automationutils.processLeakLog() | leaked 1 instance of nsCacheEntry with size 96 bytes
TEST-UNEXPECTED-FAIL | automationutils.processLeakLog() | leaked 1 instance of nsStringBuffer with size 8 bytes

Comment 1

[Phil Ringnalda (:philor)]

http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1306391382.1306396558.32183.gz

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1306746730.1306750951.11606.gz

Comment 3

[Matt Brubeck (:mbrubeck)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307153158.1307157359.14582.gz

Comment 4

[Matt Brubeck (:mbrubeck)]

http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Aurora/1307120817.1307125629.11203.gz

Comment 5

[Phil Ringnalda (:philor)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307317009.1307321284.23413.gz

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307434734.1307438980.9104.gz

Comment 7

[Phil Ringnalda (:philor)]

http://tinderbox.mozilla.org/showlog.cgi?log=Electrolysis/1308786480.1308790516.14787.gz

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1308985516.1308989587.13089.gz

Comment 9

[David :Bienvenu]

Most if not all of the mailnews xpcshell tests are leaking a single nsStringBuffer, and if I'm interpreting nsStringStats correctly, the nsStringBuffer has no allocated data (stringstats claims we're allocating and freeing the same number of bytes).

Comment 10

[David :Bienvenu]

the mailnews leakage most likely has to do with a static nsCString

Comment 11

[Matt Brubeck (:mbrubeck)]

http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Aurora/1309480900.1309485246.28585.gz

Comment 12

[Phil Ringnalda (:philor)]

http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1309519990.1309524629.31523.gz

Comment 13

[Phil Ringnalda (:philor)]

http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1309507244.1309511438.16521.gz

Comment 14

[Phil Ringnalda (:philor)]

http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1310047643.1310052401.14195.gz

Comment 15

[Phil Ringnalda (:philor)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1310080456.1310084748.8209.gz

Comment 16

[Matt Brubeck (:mbrubeck)]

http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1311712434.1311717018.14094.gz

Comment 17

[Matt Brubeck (:mbrubeck)]

http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1311694956.1311699882.26792.gz

Comment 18

[Matt Brubeck (:mbrubeck)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1311867675.1311872165.21241.gz

Comment 19

[Ed Morley [:emorley]]

Mass marking whiteboard:[orange] bugs WFM (to clean up TBPL bug suggestions) that:
* Haven't changed in > 6months
* Whose whiteboard contains none of the strings: {disabled,marked,random,fuzzy,todo,fails,failing,annotated,leave open,time-bomb}
* Passed a (quick) manual inspection of bug summary/whiteboard to ensure they weren't a false positive.

I've also gone through and searched for cases where the whiteboard wasn't labelled correctly after test disabling, by using attachment description & basic comment searches. However if the test for which this bug was about has in fact been disabled/annotated/..., please accept my apologies & reopen/mark the whiteboard appropriately so this doesn't get re-closed in the future (and please ping me via IRC or email so I can try to tweak the saved searches to avoid more edge cases).

Sorry for the spam! Filter on: #FFA500