658769 - Links in notification e-mails for KB forums should contain the locale in order to prevent a Page-not-found error

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task, P2)

Description

[Scoobidiver (away)]

Links in notification e-mails for discussion forums should contain the locale because you can monitor English discussion forums in a browser where the first preferred language is not en-US.

Comment 1

[Scoobidiver (away)]

I meant KB forums (Discussion button in articles).

Comment 2

[Underpass]

Up. Found that this bug is still present.

I received a notification for this post:

https://support.mozilla.org/kb/give-websites-ability-store-passwords-cookies-and-more/discuss/4647#post-7788

giving a "page not found error".
Thanks

Comment 3

[Kadir Topal [:atopal]]

The thing is: We don't know what language you want to get those links in. So in the absence of that, sending no language qualifier should in most cases send you to the right place. If you are a Chinese localizer it's very likely that you'll use a Chinese Browser.

So, I'm inclined to close this bug. Thoughts?

Comment 4

[Scoobidiver (away)]

(In reply to Kadir Topal [:atopal] from comment #3)
It's independent from the first preferred language of your browser.
There are two settings: "Watch KB discussion threads I start:" and "Watch KB discussion threads I comment in", so if I post a thread in an English article discussion, I want to receive notifications with en-US in the URL, and for a French article discussion with fr in the URL.

Comment 5

[Kadir Topal [:atopal]]

You are right, I mixed the two up. This is indeed an issue.

Comment 6

[Kadir Topal [:atopal]]

This is significantly more work than I had expected. We need to do this for KBforums, but also for discussion forums (which we might use for Firefox OS support) and questions.

Comment 7

[Scoobidiver (away)]

(In reply to Kadir Topal [:atopal] from comment #6)
> This is significantly more work than I had expected. We need to do this for
> KBforums, but also for discussion forums (which we might use for Firefox OS
> support) and questions.
No. It's only applicable to KBforums, there's no need to have the locale in contributor forums and questions notification emails.

Comment 8

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Scoobidiver from comment #7)
> (In reply to Kadir Topal [:atopal] from comment #6)
> > This is significantly more work than I had expected. We need to do this for
> > KBforums, but also for discussion forums (which we might use for Firefox OS
> > support) and questions.
> No. It's only applicable to KBforums, there's no need to have the locale in
> contributor forums and questions notification emails.

Yep, what Scoobidiver said. Discussion forums aren't locale specific.

Comment 9

[Kadir Topal [:atopal]]

Okay, it looks like this is fixed already. This is how an email I sent out locally looks like: 

https://support-local.allizom.org/de/kb/privater-modus/discuss/4652

or, with an English one:
https://support-local.allizom.org/en-US/kb/superheroes-wanted/discuss/4651#=
post-7802

Scoobie, Simone, please reopen if this is not fixed.

Comment 10

[Scoobidiver (away)]

It's not fixed.

Here is an extract of the notification email I received watching https://support.mozilla.org/en-US/kb/remove-babylon-toolbar-home-page-and-search-engine/discuss/4656
" To view this post on the site, click the following link, or
paste it into your browser's location bar:
https://support.mozilla.org/kb/remove-babylon-toolbar-home-page-and-search-engine/discuss/4656#post-7818 "

If I click the link, because my first browser preferred language is French I go to https://support.mozilla.org/fr/kb/remove-babylon-toolbar-home-page-and-search-engine/discuss/4656 which doesn't exist of course.

Comment 11

[Kadir Topal [:atopal]]

That's weird. This is working for me locally, but in production I only get the URL without the locale.

Ricky, any idea what might be going on here?

Comment 12

[Ricky Rosario [:rrosario, :r1cky]]

There is probably no locale activated in the celery task. We should be explicitly setting passing the locale to the reverse() call in this case.

Comment 13

[Ricky Rosario [:rrosario, :r1cky]]

Grabbing. We need to explicitly set the url in the reverse calls that happen inside `get_absolute_url()` for Thread and Post.

Comment 14

[Ricky Rosario [:rrosario, :r1cky]]

In a pull request:
https://github.com/mozilla/kitsune/pull/918

Comment 15

[Ricky Rosario [:rrosario, :r1cky]]

Landed on master:
https://github.com/mozilla/kitsune/commit/55aa32d9aef1e2acfac51bc48ea11b20e19916ca

Comment 16

[Ricky Rosario [:rrosario, :r1cky]]

Landed in prod

Comment 17

[Scoobidiver (away)]

Thanks. It works:
" To view this post on the site, click the following link, or
paste it into your browser's location bar:
https://support.mozilla.org/en-US/kb/forum-response-multiple-tabs-disable-warning/discuss/4662#post-7838 "