nsTextFrameThebes.cpp:1148:19: warning: unused variable ‘sc’

VERIFIED FIXED in mozilla6

Status

()

Core
Layout: Text
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
mozilla6
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [build_warning])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Filing bug on this warning:
> nsTextFrameThebes.cpp: In function ‘void BuildTextRuns([...])’:
> nsTextFrameThebes.cpp:1148:19: warning: unused variable ‘sc’

Variable was introduced in...
http://hg.mozilla.org/mozilla-central/diff/3fd770ef6a65/layout/generic/nsTextFrameThebes.cpp#l1.31
...(bug 253317) without any usages.  Looks like it was just left over from an earlier version of the patch that needed it.
(Assignee)

Comment 1

6 years ago
Created attachment 534264 [details] [diff] [review]
fix: remove unused variable
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #534264 - Flags: review?(jfkthame)
Comment on attachment 534264 [details] [diff] [review]
fix: remove unused variable

Yup, looks like a leftover - thanks for cleaning up!
Attachment #534264 - Flags: review?(jfkthame) → review+
(Assignee)

Comment 3

6 years ago
http://hg.mozilla.org/projects/cedar/rev/dd111452d161
Whiteboard: [build_warning] → [build_warning][fixed-in-cedar]
http://hg.mozilla.org/mozilla-central/rev/dd111452d161
Whiteboard: [build_warning][fixed-in-cedar] → [build_warning]
Target Milestone: --- → mozilla6
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Comment 5

6 years ago
Mozilla/5.0 (Windows NT 5.1; rv:8.0a1) Gecko/20110728 Firefox/8.0a1

Looked at: http://hg.mozilla.org/mozilla-central/file/f5f1e3822540/layout/generic/nsTextFrameThebes.cpp#l1187
Based on this I am marking this: VERIFIED FIXED.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.