Closed
Bug 658834
Opened 14 years ago
Closed 14 years ago
nsTextFrameThebes.cpp:1148:19: warning: unused variable ‘sc’
Categories
(Core :: Layout: Text and Fonts, defect)
Core
Layout: Text and Fonts
Tracking
()
VERIFIED
FIXED
mozilla6
People
(Reporter: dholbert, Assigned: dholbert)
Details
(Whiteboard: [build_warning])
Attachments
(1 file)
703 bytes,
patch
|
jfkthame
:
review+
|
Details | Diff | Splinter Review |
Filing bug on this warning:
> nsTextFrameThebes.cpp: In function ‘void BuildTextRuns([...])’:
> nsTextFrameThebes.cpp:1148:19: warning: unused variable ‘sc’
Variable was introduced in...
http://hg.mozilla.org/mozilla-central/diff/3fd770ef6a65/layout/generic/nsTextFrameThebes.cpp#l1.31
...(bug 253317) without any usages. Looks like it was just left over from an earlier version of the patch that needed it.
Assignee | ||
Comment 1•14 years ago
|
||
Comment 2•14 years ago
|
||
Comment on attachment 534264 [details] [diff] [review]
fix: remove unused variable
Yup, looks like a leftover - thanks for cleaning up!
Attachment #534264 -
Flags: review?(jfkthame) → review+
Assignee | ||
Comment 3•14 years ago
|
||
Whiteboard: [build_warning] → [build_warning][fixed-in-cedar]
Comment 4•14 years ago
|
||
Whiteboard: [build_warning][fixed-in-cedar] → [build_warning]
Target Milestone: --- → mozilla6
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 5•14 years ago
|
||
Mozilla/5.0 (Windows NT 5.1; rv:8.0a1) Gecko/20110728 Firefox/8.0a1
Looked at: http://hg.mozilla.org/mozilla-central/file/f5f1e3822540/layout/generic/nsTextFrameThebes.cpp#l1187
Based on this I am marking this: VERIFIED FIXED.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•