The default bug view has changed. See this FAQ.

"ABORT: Reset() expects non-null URI for referenced elem"

RESOLVED FIXED in mozilla6

Status

()

Core
Layout
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Jesse Ruderman, Assigned: dholbert)

Tracking

({assertion, regression, testcase})

Trunk
mozilla6
assertion, regression, testcase
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

6 years ago
Created attachment 534272 [details]
testcase (asserts fatally when loaded)

###!!! ABORT: Reset() expects non-null URI for referenced elem: 'aURI', file content/base/src/nsReferencedElement.cpp, line 55

This abort was added in http://hg.mozilla.org/mozilla-central/rev/655514007ebd (bug 308590 patch 5).
(Reporter)

Comment 1

6 years ago
Created attachment 534273 [details]
stack trace
(Assignee)

Comment 2

6 years ago
The assert may very well be bogus.
(Assignee)

Comment 3

6 years ago
Created attachment 534278 [details] [diff] [review]
fix

(Confirmed in debug m-c build.)

Yeah, I think the assert is bogus.

Previously (before bug 308590), nsReferencedElement::Reset() began like so:
> 81   Unlink();
> 82 
> 83   nsCOMPtr<nsIURL> url = do_QueryInterface(aURI);
> 84   if (!url)
> 85     return;

I mistakenly assumed that line 84 there was simply a check for "Is aURI a nsIURL?", but turns out it was *also* serving the purpose of checking "Is aURI non-null".

Attached patch removes the bogus ABORT_IF_FALSE and restores a null-check early-return.  Also includes this bug's patch as a crash-test.
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #534278 - Flags: review?(roc)
Comment on attachment 534278 [details] [diff] [review]
fix

Review of attachment 534278 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #534278 - Flags: review?(roc) → review+
(Assignee)

Comment 5

6 years ago
http://hg.mozilla.org/projects/cedar/rev/96fae135f592
Whiteboard: [fixed-in-cedar]
(Assignee)

Updated

6 years ago
OS: Mac OS X → All
Hardware: x86 → All
http://hg.mozilla.org/mozilla-central/rev/96fae135f592
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-cedar]
Target Milestone: --- → mozilla6
(Assignee)

Comment 7

6 years ago
Comment on attachment 534278 [details] [diff] [review]
fix

Requesting approval to land on aurora, as a followup to bug 308590.  

This is a trivial patch to fix a null-pointer crash. Includes crashtest.
Attachment #534278 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 8

6 years ago
(In reply to comment #7)
> This is a trivial patch to fix a null-pointer crash. Includes crashtest.

(a _new_ null-pointer crash, that is)
Attachment #534278 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 9

6 years ago
Gah, sorry -- I'm failing today at remembering whether things landed before or after the last aurora merge.  (I thought the merge was longer ago than it actually was.)

The checkin in comment 6 beat the merge, so this is already in aurora.
(Assignee)

Updated

6 years ago
Attachment #534278 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.