When a page is loading, the status panel should appear immediately rather than being faded in (affects page load time)

RESOLVED FIXED in Firefox 5

Status

()

Firefox
General
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

(Blocks: 1 bug, {perf, regression})

4.0 Branch
Firefox 6
perf, regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox5 fixed, status2.0 wontfix)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 534280 [details] [diff] [review]
patch

See bug 655930 comment 30

The only part of bug 541656 that could reasonably affect page load time is this part, as far as I can see:

>--- a/browser/base/content/browser.css
>+++ b/browser/base/content/browser.css

> statuspanel {
>   -moz-binding: url("chrome://browser/content/tabbrowser.xml#statuspanel");
>   position: fixed;
>   margin-top: -3em;
>   left: 0;
>+  max-width: 50%;
>+  -moz-transition: opacity 100ms ease-out;
> }
> 
> statuspanel:-moz-locale-dir(ltr)[mirror],
> statuspanel:-moz-locale-dir(rtl):not([mirror]) {
>   left: auto;
>   right: 0;
> }
> 
> statuspanel[label=""] {
>-  visibility: collapse;
>+  opacity: 0;
>+  pointer-events: none;
> }

... the opacity transition in particular.

I pushed the attached patch to Try, WinXP numbers went from 358 to 338:

baseline: http://tbpl.mozilla.org/?tree=Try&rev=177ceed2ffc6
with fix: http://tbpl.mozilla.org/?tree=Try&rev=64e98778133f
Attachment #534280 - Flags: review?(sdwilsh)
(Assignee)

Comment 1

6 years ago
> WinXP numbers went from 358 to 338

Rather to 336. The rerun results don't show up on tbpl for whatever reason.
Attachment #534280 - Flags: review+
(Assignee)

Updated

6 years ago
Attachment #534280 - Flags: review?(sdwilsh)
(Assignee)

Comment 2

6 years ago
http://hg.mozilla.org/mozilla-central/rev/f5dbf215f9ea
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 6
Version: Trunk → 4.0 Branch
(Assignee)

Updated

6 years ago
Attachment #534280 - Flags: approval-mozilla-beta?
(Assignee)

Updated

6 years ago
status-firefox5: --- → affected
(Assignee)

Updated

6 years ago
status2.0: --- → wontfix
You can get the average of the reruns with this script (which I just run in Scratchpad):
https://gist.github.com/971090/f26a65faf4817acead2b453f217568bfc6c1d936

While this is a nice win, it's still not the entire regression that I found.
Comment on attachment 534280 [details] [diff] [review]
patch

Approved for the mozilla-beta repository, a=dveditz for release-drivers
Attachment #534280 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
(Assignee)

Comment 5

6 years ago
http://hg.mozilla.org/releases/mozilla-beta/rev/321c235ffaf4
status-firefox5: affected → fixed
If you're not doing a transition on opacity anymore, can you make the statuspanel display:none when it's not needed? That would reduce overhead when it's not visible.
(Assignee)

Comment 7

6 years ago
(In reply to comment #6)
> If you're not doing a transition on opacity anymore, can you make the
> statuspanel display:none when it's not needed? That would reduce overhead
> when it's not visible.

The transition is still there for link target URLs.

If the overhead is substantial, we could probably replace that transition with a longer delay, after which the panel would appear immediately.
(Assignee)

Comment 8

6 years ago
(In reply to comment #3)
> While this is a nice win, it's still not the entire regression that I found.

(In reply to comment #6)
> If you're not doing a transition on opacity anymore, can you make the
> statuspanel display:none when it's not needed? That would reduce overhead
> when it's not visible.

I tested display:none instead of opacity:0 on the try server:
http://hg.mozilla.org/try/rev/9f1d684c834e

This seems to be no win for tp4 at least:
http://perf.snarkfest.net/compare-talos/index.html?oldRevs=d856cbfa6c38&newRev=9f1d684c834e&tests=tp4&submit=true
You need to log in before you can comment on or make changes to this bug.