658878 - [SeaMonkey] comm-central busted due to bug 616999 and bug 658666/ switching xpcshell to manifests

Status: RESOLVED WORKSFORME

(SeaMonkey :: Build Config, defect)

Description

[Ian Neal]

Attachment: First attempt at a patch

This WIP patch just copies what was done for TB with one addition for SM.

Comment 1

[Philip Chee]

Comment on attachment 534302 [details] [diff] [review]
First attempt at a patch

> +#[include:mail/base/test/unit/xpcshell.ini]
> +#[include:mail/steel/mac/xpcshell.ini]
> +#run-if.os = mac
> +#[include:mail/steel/nomac/xpcshell.ini]
> +#skip-if.os = mac
> +#[include:mail/components/test/unit/xpcshell.ini]

Test will fail since we do not have the |platformIsMac| method in SMILE

Comment 2

[Ian Neal]

Attachment: xpcshell.ini patch [Checked in: Comment 4]

This patch basically copies what was done for TB with a few TB specific lines removed and one for SM added for places.

Comment 3

[[e-mail]]

Comment on attachment 534330 [details] [diff] [review]
xpcshell.ini patch [Checked in: Comment 4]

>+[include:mozilla/chrome/test/unit_ipc/xpcshell.ini]
>+run-if.config = ipc
>+
>+[include:mozilla/extensions/cookie/test/unit_ipc/xpcshell.ini]
>+run-if.config = ipc
>+
>+[include:mozilla/ipc/testshell/tests/xpcshell.ini]
>+run-if.config = ipc
>+
>+[include:mozilla/modules/libpref/test/unit_ipc/xpcshell.ini]
>+run-if.config = ipc
>+
>+[include:mozilla/netwerk/test/unit_ipc/xpcshell.ini]
>+run-if.config = ipc
>+
>+[include:mozilla/netwerk/cookie/test/unit_ipc/xpcshell.ini]
>+run-if.config = ipc
>+
>+[include:mozilla/toolkit/components/contentprefs/tests/unit_ipc/xpcshell.ini]
>+run-if.config = ipc
>+
>+[include:mozilla/uriloader/exthandler/tests/unit_ipc/xpcshell.ini]
>+run-if.config = ipc
Hmm, I thought ipc wasn't optional any more...

Comment 4

[Ian Neal]

Comment on attachment 534330 [details] [diff] [review]
xpcshell.ini patch [Checked in: Comment 4]

http://hg.mozilla.org/comm-central/rev/f5cf5a444540

As far as I can see MOZ_IPC is still around.

Comment 5

[Philip Chee]

> As far as I can see MOZ_IPC is still around.
Bug 639754 - Remove MOZ_IPC checks since IPC is always built now

Comment 6

[Ian Neal]

Still some left around in suite as well as core
http://mxr.mozilla.org/comm-central/search?string=MOZ_IPC

Comment 7

[Philip Chee]

> Still some left around in suite as well as core
I filed Bug 659940 (Remove MOZ_IPC checks from comm-central since IPC is always built now)

Comment 8

[Philip Chee]

IanN: Is there anything more to be done in this bug?

Comment 9

[Ian Neal]

Well, in theory, this can close when bug 658666 closes as this is mirroring it.

Comment 10

[Ian Neal]

(In reply to comment #9)
> Well, in theory, this can close when bug 658666 closes as this is mirroring
> it.

And of course, any SM versions of patches from that bug have been created, etc.

Comment 11

[Phoenix]

Still need to be open?

Comment 12

[Philip Chee]

> Still need to be open?
No.