Closed Bug 658878 Opened 9 years ago Closed 8 years ago

[SeaMonkey] comm-central busted due to bug 616999 and bug 658666/ switching xpcshell to manifests

Categories

(SeaMonkey :: Build Config, defect, blocker)

defect
Not set
blocker

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch First attempt at a patch (obsolete) — Splinter Review
This WIP patch just copies what was done for TB with one addition for SM.
Severity: normal → blocker
Comment on attachment 534302 [details] [diff] [review]
First attempt at a patch

> +#[include:mail/base/test/unit/xpcshell.ini]
> +#[include:mail/steel/mac/xpcshell.ini]
> +#run-if.os = mac
> +#[include:mail/steel/nomac/xpcshell.ini]
> +#skip-if.os = mac
> +#[include:mail/components/test/unit/xpcshell.ini]

Test will fail since we do not have the |platformIsMac| method in SMILE
This patch basically copies what was done for TB with a few TB specific lines removed and one for SM added for places.
Attachment #534302 - Attachment is obsolete: true
Attachment #534330 - Flags: review?(neil)
Comment on attachment 534330 [details] [diff] [review]
xpcshell.ini patch [Checked in: Comment 4]

>+[include:mozilla/chrome/test/unit_ipc/xpcshell.ini]
>+run-if.config = ipc
>+
>+[include:mozilla/extensions/cookie/test/unit_ipc/xpcshell.ini]
>+run-if.config = ipc
>+
>+[include:mozilla/ipc/testshell/tests/xpcshell.ini]
>+run-if.config = ipc
>+
>+[include:mozilla/modules/libpref/test/unit_ipc/xpcshell.ini]
>+run-if.config = ipc
>+
>+[include:mozilla/netwerk/test/unit_ipc/xpcshell.ini]
>+run-if.config = ipc
>+
>+[include:mozilla/netwerk/cookie/test/unit_ipc/xpcshell.ini]
>+run-if.config = ipc
>+
>+[include:mozilla/toolkit/components/contentprefs/tests/unit_ipc/xpcshell.ini]
>+run-if.config = ipc
>+
>+[include:mozilla/uriloader/exthandler/tests/unit_ipc/xpcshell.ini]
>+run-if.config = ipc
Hmm, I thought ipc wasn't optional any more...
Attachment #534330 - Flags: review?(neil) → review+
Comment on attachment 534330 [details] [diff] [review]
xpcshell.ini patch [Checked in: Comment 4]

http://hg.mozilla.org/comm-central/rev/f5cf5a444540

As far as I can see MOZ_IPC is still around.
Attachment #534330 - Attachment description: xpcshell.ini patch → xpcshell.ini patch [Checked in: Comment 4]
> As far as I can see MOZ_IPC is still around.
Bug 639754 - Remove MOZ_IPC checks since IPC is always built now
Still some left around in suite as well as core
http://mxr.mozilla.org/comm-central/search?string=MOZ_IPC
> Still some left around in suite as well as core
I filed Bug 659940 (Remove MOZ_IPC checks from comm-central since IPC is always built now)
IanN: Is there anything more to be done in this bug?
Well, in theory, this can close when bug 658666 closes as this is mirroring it.
(In reply to comment #9)
> Well, in theory, this can close when bug 658666 closes as this is mirroring
> it.

And of course, any SM versions of patches from that bug have been created, etc.
Still need to be open?
> Still need to be open?
No.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.