The default bug view has changed. See this FAQ.

Remove nsIDOMDocumentStyle

VERIFIED FIXED in mozilla7

Status

()

Core
DOM: CSS Object Model
--
minor
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

({dev-doc-complete})

Trunk
mozilla7
dev-doc-complete
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 534321 [details] [diff] [review]
Patch v1
Attachment #534321 - Flags: review?(roc)
Flags: in-testsuite-
Comment on attachment 534321 [details] [diff] [review]
Patch v1

Review of attachment 534321 [details] [diff] [review]:
-----------------------------------------------------------------

I am not a content peer so this needs additional review from someone who is.

::: dom/interfaces/core/nsIDOMDocument.idl
@@ +217,1 @@
>  };

nsIDOMDocument needs an IID rev.
Attachment #534321 - Flags: review?(roc)
Attachment #534321 - Flags: review?(jst)
Attachment #534321 - Flags: review+
(Assignee)

Comment 2

6 years ago
Yes, will do (and its subclasses as well).
Comment on attachment 534321 [details] [diff] [review]
Patch v1

r=jst, but yeah, rev the IID for nsIDOMDocument, and also for other interfaces that directly or indirectly inherit nsIDOMDocument (nsIDOMHTMLDocument, nsIDOMXMLDocument, and nsIDOMSVGDocument), just because they tend to be interfaces that are very commonly used by binary extensions etc.
Attachment #534321 - Flags: review?(jst) → review+
(Assignee)

Comment 4

6 years ago
http://hg.mozilla.org/mozilla-central/rev/08d91c51adb5
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [needs review]
Target Milestone: --- → mozilla7
(Assignee)

Updated

6 years ago
Keywords: dev-doc-needed
Keywords: dev-doc-needed → dev-doc-complete
(Assignee)

Updated

6 years ago
Depends on: 667021

Comment 5

6 years ago
The actual file nsIDOMDocumentCSS.idl doesn't seem to have been deleted?
(Assignee)

Comment 6

6 years ago
Indeed. I'll remove it when I next need to push.
(Assignee)

Comment 7

6 years ago
Or actually, Ed is going to in bug 667021.

Comment 8

6 years ago
Thanks - I wasn't nit-picking, I have a idl -> C# compiler which couldn't compile that file.
It seems to have been removed after seeing the bug in comment 7.
Setting resolution to VERIFIED FIXED.
Thanks.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.