Closed Bug 658904 Opened 8 years ago Closed 8 years ago

Remove nsIDOMDocumentStyle

Categories

(Core :: DOM: CSS Object Model, defect, minor)

defect
Not set
minor

Tracking

()

VERIFIED FIXED
mozilla7

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

Attached patch Patch v1Splinter Review
No description provided.
Attachment #534321 - Flags: review?(roc)
Flags: in-testsuite-
Comment on attachment 534321 [details] [diff] [review]
Patch v1

Review of attachment 534321 [details] [diff] [review]:
-----------------------------------------------------------------

I am not a content peer so this needs additional review from someone who is.

::: dom/interfaces/core/nsIDOMDocument.idl
@@ +217,1 @@
>  };

nsIDOMDocument needs an IID rev.
Attachment #534321 - Flags: review?(roc)
Attachment #534321 - Flags: review?(jst)
Attachment #534321 - Flags: review+
Yes, will do (and its subclasses as well).
Comment on attachment 534321 [details] [diff] [review]
Patch v1

r=jst, but yeah, rev the IID for nsIDOMDocument, and also for other interfaces that directly or indirectly inherit nsIDOMDocument (nsIDOMHTMLDocument, nsIDOMXMLDocument, and nsIDOMSVGDocument), just because they tend to be interfaces that are very commonly used by binary extensions etc.
Attachment #534321 - Flags: review?(jst) → review+
http://hg.mozilla.org/mozilla-central/rev/08d91c51adb5
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [needs review]
Target Milestone: --- → mozilla7
Keywords: dev-doc-needed
Depends on: 667021
The actual file nsIDOMDocumentCSS.idl doesn't seem to have been deleted?
Indeed. I'll remove it when I next need to push.
Or actually, Ed is going to in bug 667021.
Thanks - I wasn't nit-picking, I have a idl -> C# compiler which couldn't compile that file.
It seems to have been removed after seeing the bug in comment 7.
Setting resolution to VERIFIED FIXED.
Thanks.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.