658959 - Fix DownloadManager (and tests) usage of deprecated Storage binding APIs.

Status: RESOLVED FIXED

(SeaMonkey :: Download & File Handling, defect)

Description

[Philip Chee]

Bug 584316 - Fix DownloadManager usage of deprecated Storage binding APIs
Bug 645049 - Update tests to no longer use a deprecated API

From Bug 584316:

> bug 507414 declared deprecated a bunch of binding functions download manager
> uses, you should update to the new code.

We will need to update our download manager UI code and tests since the APIs have changed on trunk.

Attachment 521862 [details] [diff] and Attachment 521875 [details] [diff] look relevant.

Comment 1

[Edmund Wong (:ewong)]

Attachment: Fix DownloadManager (and tests) usage of deprecated Storage binding APIs.

Comment 2

[Philip Chee]

Comment on attachment 535934 [details] [diff] [review]
Fix DownloadManager (and tests) usage of deprecated Storage binding APIs.

bindStringParameter() and bindInt64Parameter() need to be replaced as well.

> +++ b/suite/common/downloads/tests/chrome/test_action_keys_respect_focus.xul
>        stmt.bindStringParameter(0, "Finished Download");
>        stmt.bindStringParameter(1, filePath);
>        stmt.bindStringParameter(2, "http://" + site + "/file");
> -      stmt.bindInt32Parameter(3, dm.DOWNLOAD_FINISHED);
> +      stmt.bindByIndex(3, dm.DOWNLOAD_FINISHED);

stmt.bindStringParameter() => stmt.bindByIndex(()
(Other tests as well)

> +++ b/suite/common/downloads/tests/chrome/test_multiword_search.xul
>        stmt.bindStringParameter(0, "Super Pimped Download");
>        stmt.bindStringParameter(1, filePath);
>        stmt.bindStringParameter(2, "http://" + site + "/file");
> -      stmt.bindInt32Parameter(3, dm.DOWNLOAD_FINISHED);
> +      stmt.bindByIndex(3, dm.DOWNLOAD_FINISHED);
>        stmt.bindInt64Parameter(4, new Date(1985, 7, 2) * 1000);
>        stmt.bindInt64Parameter(5, 111222333444);

stmt.bindInt64Parameter() => stmt.bindByIndex(()
(Other tests as well)

Comment 3

[Philip Chee]

In /suite/common/contentAreaClick.js addToUrlbarHistory() uses bindStringParameter() twice.

Comment 4

[Edmund Wong (:ewong)]

Attachment: Fix DownloadManager (and tests) usage of deprecated Storage binding APIs. (v2)

Comment 5

[Edmund Wong (:ewong)]

Attachment: Fix DownloadManager (and tests) usage of deprecated Storage binding APIs.(v3)

Comment 6

[Philip Chee]

Comment on attachment 536078 [details] [diff] [review]
Fix DownloadManager (and tests) usage of deprecated Storage binding APIs.(v3)

Passed all the download manager tests. Also tested clicking on links.

Comment 7

[Philip Chee]

Neil would be an appropriate reviewer.

Comment 8

[Philip Chee]

Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/2e4cb4a1ea64