659048 - Use extensions.checkCompatibility.nightly to disable compatibility in nightly builds

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Dave Townsend [:mossop]]

So the main devs don't have to change a new preference every 6 weeks. Users of other channels should be pushed to the add-on compatibility reporter

Comment 1

[Dave Townsend [:mossop]]

Attachment: patch rev 1

This switched to only using the versions string on the aurora, beta and release channels. Everywhere else (nightly, self-built etc.) it uses the nightly pref.

Comment 2

[Dave Townsend [:mossop]]

Landed: http://hg.mozilla.org/mozilla-central/rev/a02258e48c4d

Comment 3

[Daniel C]

#ifdef MOZ_COMPATABILITY_NIGHTLY
		const PREF_EM_CHECK_COMPATIBILITY =

Note the spelling difference. The first is incorrect, the second is correct. Please change it, it makes my eyes hurt.

Comment 4

[Dave Townsend [:mossop]]

Oops. Fancy providing a patch to fix it?

Comment 5

[Daniel C]

I could but I don't even have a local repository set up at the moment so it would be much quicker for someone else to patch it. There's just one change in each of the following 3 files.

toolkit/mozapps/extensions/Makefile.in
toolkit/mozapps/extensions/XPIProvider.jsm
toolkit/mozapps/extensions/content/extensions.js

Comment 6

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Reopened the bug until someone pushes the patch to fix the issue from comment 3, 4, 5.

Comment 7

[Dave Townsend [:mossop]]

Small typos that don't affect the functionality of the bug fix aren't worth keeping a bug open for. If you want to provide a patch to correct it then I'll review it and land it

Comment 8

[pal-moz]

after installing add-ons (with modified install.rdf/maxver=9.0a1) into new/clean profile, new config "nightly.disableCheckCompatibility/boolean/false" is created.

correct ?


old config is "extensions.checkCompatibility.(version-number)/boolean/false"

Comment 9

[Dave Townsend [:mossop]]

(In reply to comment #8)
> after installing add-ons (with modified install.rdf/maxver=9.0a1) into
> new/clean profile, new config
> "nightly.disableCheckCompatibility/boolean/false" is created.

If you're modifying the install.rdf then you don't need to do anything, otherwise as the bug summary says, the new pref is extensions.checkCompatibility.nightly

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:7.0a1) Gecko/20110630 Firefox/7.0a1

Comment 11

[Dave Townsend [:mossop]]

I've backed this out of aurora as it wasn't working right there for some reason. This is no loss as it was only meant to affect Nightly anyway. I've filed bug 669541 to get it fixed before the next merge.

http://hg.mozilla.org/releases/mozilla-aurora/rev/92120afb1a58