659135 - Set up initenv to be more flexible than just having an auth object

Status: RESOLVED FIXED

(Cloud Services :: Server: Core, defect)

Description

[Toby Elliott [:telliott]]

The initenv in support.py currently sets up the environment by parsing the configs, then setting up an auth object from config. As various projects start to require more than just an auth object, it would be good if the initenv could be told to load other classes from config as well so that those could be tested as needed

Comment 1

[Toby Elliott [:telliott]]

Attachment: Adds the ability to add arbitrary extra env classes to the environ

Comment 2

[Tarek Ziadé (:tarek)]

What's load_and_configure ? it seems to be missing from the patch

Comment 3

[Toby Elliott [:telliott]]

It's the bit in the other patch I'm still waiting for review on. Bug 659136

Comment 4

[Tarek Ziadé (:tarek)]

Comment on attachment 535136 [details] [diff] [review]
Adds the ability to add arbitrary extra env classes to the environ

Review of attachment 535136 [details] [diff] [review]:
-----------------------------------------------------------------

looks good. two warnings to fix

services/tests/support.py:47:1: E302 expected 2 blank lines, found 1
services/tests/support.py:83:80: E501 line too long (80 characters)

Comment 5

[Toby Elliott [:telliott]]

Updated in http://hg.mozilla.org/services/server-core/rev/66551c435b23