Crashing on startup [@ DisableFontActivation() ]

RESOLVED FIXED

Status

()

Core
Layout: Text
--
blocker
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Sam Liu, Assigned: jtd)

Tracking

({crash, regression})

Trunk
x86_64
Mac OS X
crash, regression
Points:
---

Firefox Tracking Flags

(firefox6-)

Details

(Whiteboard: jesse nominated without comment, crash signature)

Attachments

(2 attachments)

(Reporter)

Description

6 years ago
Created attachment 534604 [details]
Stacktrace
(Reporter)

Comment 1

6 years ago
Note: Local builds crash but nightly build does not crash.

Updated

6 years ago
tracking-firefox6: --- → ?
(Assignee)

Comment 2

6 years ago
Hmmm, when you crash what are the values of mainBundleID and mainBundle?  It looks like you're stopping on a breakpoint, what's the stack when it actually crashes?
(Assignee)

Comment 3

6 years ago
Hmmm, unlike other API's CFRelease(NULL) is not allowed.

http://developer.apple.com/library/mac/#documentation/CoreFoundation/Reference/CFTypeRef/Reference/reference.html#//apple_ref/c/func/CFRelease
(Assignee)

Comment 4

6 years ago
Created attachment 534647 [details] [diff] [review]
patch, null check bundle ids before releasing
Assignee: nobody → jdaggett
Attachment #534647 - Flags: review?(roc)
Comment on attachment 534647 [details] [diff] [review]
patch, null check bundle ids before releasing

Review of attachment 534647 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #534647 - Flags: review?(roc) → review+
http://hg.mozilla.org/mozilla-central/rev/58083c2147e2
Is there a need to get the bundle ID at all? I notice that the doc for CTFontManagerSetAutoActivationSetting says "If NULL, the current application bundle is used"; wouldn't that serve the purpose?
(Assignee)

Comment 8

6 years ago
(In reply to comment #7)
> Is there a need to get the bundle ID at all? I notice that the doc for
> CTFontManagerSetAutoActivationSetting says "If NULL, the current application
> bundle is used"; wouldn't that serve the purpose?

Nope.  I coded the initial patch on bug 567552 that way and it turns out passing in NULL affects the *global* setting, not a per-process setting.  If you experiment with this you'll see that it clears the "Automatic Font Activation" pref in FontBook.  Seems to be an Apple docs bug, unless I missing something.
(In reply to comment #8)
> (In reply to comment #7)
> > Is there a need to get the bundle ID at all? I notice that the doc for
> > CTFontManagerSetAutoActivationSetting says "If NULL, the current application
> > bundle is used"; wouldn't that serve the purpose?
> 
> Nope.  I coded the initial patch on bug 567552 that way and it turns out
> passing in NULL affects the *global* setting, not a per-process setting.  If
> you experiment with this you'll see that it clears the "Automatic Font
> Activation" pref in FontBook.  Seems to be an Apple docs bug, unless I
> missing something.

Fair enough; I didn't try it myself, just wondered based on what the doc said. Reported the bug to Apple?
(Assignee)

Comment 10

6 years ago
(In reply to comment #9)
> Fair enough; I didn't try it myself, just wondered based on what the doc
> said. Reported the bug to Apple?

No, but you're right, I should.
(Reporter)

Comment 11

6 years ago
Fixed as of rev 58083c2147e2
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
Whiteboard: jesse nominated without comment

Comment 12

6 years ago
please nominate the patch with a risk analysis if you think it's safe for taking into 6 Aurora.
tracking-firefox6: ? → -
It looks like this is on Aurora already. It's listed in:
https://hg.mozilla.org/releases/mozilla-aurora/filelog/d8b797975700/gfx/thebes/gfxPlatformMac.cpp
Crash Signature: [@ DisableFontActivation() ]
You need to log in before you can comment on or make changes to this bug.