--enable-shared-js builds are broken

RESOLVED FIXED in mozilla6

Status

()

Core
DOM
P1
normal
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

Trunk
mozilla6
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox5- affected)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Actually, any build that tries to use js::ForceFrame without statically linking JS, because the destructor is inline but uses non-exported stuff.

This broke all my builds, for example.  :(
(Assignee)

Updated

6 years ago
status-firefox5: --- → affected
tracking-firefox5: --- → ?
tracking-firefox6: --- → ?
(Assignee)

Comment 1

6 years ago
Created attachment 534648 [details] [diff] [review]
Don't inline a constructor that consumers can't actually inline without statically linking to JS.
Attachment #534648 - Flags: review?(luke)
(Assignee)

Updated

6 years ago
OS: Mac OS X → All
Priority: -- → P1
Hardware: x86 → All
Comment on attachment 534648 [details] [diff] [review]
Don't inline a constructor that consumers can't actually inline without statically linking to JS.

It makes me sad that this is necessary.
Attachment #534648 - Flags: review?(luke) → review+
Pushed:
http://hg.mozilla.org/mozilla-central/rev/837f762860af
Status: NEW → RESOLVED
Last Resolved: 6 years ago
tracking-firefox6: ? → ---
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
No need to track: release drivers are conflicted on whether we'd take a patch which doesn't affect our release builds on the beta channel...
tracking-firefox5: ? → -
Comment on attachment 534648 [details] [diff] [review]
Don't inline a constructor that consumers can't actually inline without statically linking to JS.

I think we should take this for beta.
Attachment #534648 - Flags: approval-mozilla-beta?
Attachment #534648 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment 6

6 years ago
This doesn't apply cleanly to mozilla-beta. Rescinding approval as we are late in beta anyway.

Updated

6 years ago
Attachment #534648 - Flags: approval-mozilla-beta+ → approval-mozilla-beta-
(Assignee)

Comment 7

6 years ago
Um... Making this apply cleanly is a trivial merge, which I was going to do on Monday.

Either way, though.  I guess it doesn't matter that much if our beta and fx5 can't be built in some supported configurations....
You need to log in before you can comment on or make changes to this bug.