659244 - p7m attachments are skipped in printing

Status: RESOLVED FIXED

(MailNews Core :: Printing, defect)

Description

[intendentedelleacque]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; it; rv:1.9.2.17) Gecko/20110420 Firefox/3.6.17
Build Identifier: 

Once that you can have p7m attachments visible (using  TB 3.3 alpha or using TB 3.1 or lower with the extension Smart P7M Support), you can see that they're not visible in printing and printing preview.

In my opinion this is due to http://mxr.mozilla.org/comm-central/source/mailnews/mime/emitters/src/nsMimeHtmlEmitter.cpp#419

Lines 419-425 should be changed from

419   if ( (contentType) &&
420        ((!strcmp(contentType, APPLICATION_XPKCS7_MIME)) ||
421         (!strcmp(contentType, APPLICATION_PKCS7_MIME)) ||
422         (!strcmp(contentType, APPLICATION_XPKCS7_SIGNATURE)) ||
423         (!strcmp(contentType, APPLICATION_PKCS7_SIGNATURE)) ||
424         (!strcmp(contentType, TEXT_VCARD)))
425      )

to

419   if ( (contentType) &&
420        ((!strcmp(contentType, APPLICATION_XPKCS7_SIGNATURE)) ||
421         (!strcmp(contentType, APPLICATION_PKCS7_SIGNATURE)) ||
422         (!strcmp(contentType, TEXT_VCARD)))
423      )

It should not create troubles or regression, because this function should be called just in printing.

Unluckly I've not skill enough to write a patch, but it shouldn't be difficult to do it based on the notes above.



Reproducible: Always

Steps to Reproduce:
1. use TB 3.3alpha or TB with the extension Smart p7m Support
2. select a message with a p7m attachment
3 [review]. run print-preview or print

Actual Results:  
p7m attachment is not visible in print-preview/print

Expected Results:  
p7m should be visible in print-preview/print

Comment 1

[Ludovic Hirlimann [:Usul]]

Unfortunately we backout a bug 243833.

Comment 2

[Ludovic Hirlimann [:Usul]]

Unfortunately we backout a bug 243833.

Comment 3

[intendentedelleacque]

(In reply to comment #2)
> Unfortunately we backout a bug 243833.

Ok, I'm reading about this.

But this bug concerns a code totally different and - if the notes on the source code are exact - used just in printing.

Comment 4

[Magnus Melin [:mkmelin]]

Fixed by bug 243833 (according to bug 243833 comment 156)