move content/xul/*.xul tests from mochitest-plain to mochitest-chrome

RESOLVED FIXED

Status

()

Core
XUL
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jmaher, Assigned: jmaher)

Tracking

(Blocks: 1 bug)

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [specialpowers])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
with special powers and the push to remove universalxpconnect, it is a good time to revisit our tests and try to move mochitests that use a lot of XUL to run in the mochitest-chrome harness
(Assignee)

Updated

6 years ago
Blocks: 462483
Summary: move content/xul/base/test/*.xul tests from mochitest-plain to mochitest-chrome → move content/xul/*.xul tests from mochitest-plain to mochitest-chrome
Whiteboard: [specialpowers]
(Assignee)

Comment 1

6 years ago
Created attachment 534718 [details] [diff] [review]
move content/xul/*.xul tests to mochitest-chrome (1.0)

this patch moves these tests to mochitest-chrome:
/content/xul/content/test/test_bug233643.xul
/content/xul/content/test/test_bug330705-2.xul
/content/xul/document/test/test_bug199692.xul
/content/xul/document/test/test_bug311681.xul
/content/xul/document/test/test_bug335375.xul
/content/xul/document/test/test_bug391002.xul
/content/xul/document/test/test_bug403868.xul
/content/xul/document/test/test_bug414907.xul
/content/xul/document/test/test_bug418216.xul
/content/xul/document/test/test_bug445177.xul
/content/xul/document/test/test_bug449457.xul
/content/xul/document/test/test_bug468176.xul
/content/xul/templates/tests/chrome/bug441785-1.rdf
/content/xul/templates/tests/chrome/bug441785-2.rdf
/content/xul/templates/tests/chrome/test_bug441785.xul
/content/xul/templates/tests/chrome/test_sortservice.xul

I would like to make sure that these tests will be getting the intended coverage before moving the tests.
Assignee: nobody → jmaher
Attachment #534718 - Flags: review?(bzbarsky)
Attachment #534718 - Flags: feedback?(ted.mielczarek)
It'd really work better to ask the test authors...  I'll see if I can make time for this, but I'd have to go through and read the tests and bugs carefully to figure out what all is going on....
(Assignee)

Comment 3

6 years ago
:bz, can you verify these tests will be fine in mochitest-chrome:
/content/xul/document/test/test_bug311681.xul
/content/xul/document/test/test_bug403868.xul
/content/xul/templates/tests/chrome/test_bug441785.xul

:smaug, can you verify these tests:
/content/xul/document/test/test_bug445177.xul
/content/xul/document/test/test_bug449457.xul
/content/xul/document/test/test_bug468176.xul

:waldo, can you verify this test:
/content/xul/document/test/test_bug199692.xul

:arno, can you verify these tests:
/content/xul/document/test/test_bug391002.xul
/content/xul/document/test/test_bug414907.xul
/content/xul/document/test/test_bug418216.xul

ehsan, can you verify this test:
/content/xul/content/test/test_bug233643.xul

ian, can you verify this test:
/content/xul/content/test/test_bug330705-2.xul

neal, cna you verify this test:
/content/xul/templates/tests/chrome/test_sortservice.xul

Comment 4

6 years ago
cc'ing right people for:
/content/xul/content/test/test_bug330705-2.xul
/content/xul/templates/tests/chrome/test_sortservice.xul
Status: NEW → ASSIGNED
Comment on attachment 534718 [details] [diff] [review]
move content/xul/*.xul tests to mochitest-chrome (1.0)

Review of attachment 534718 [details] [diff] [review]:
-----------------------------------------------------------------

The mechanics look fine to me, needs signoff from subject matter experts, obviously.

::: content/xul/content/test/Makefile.in
@@ +54,3 @@
>   		test_bug398289.html \
>   		398289-resource.xul \
>   		$(NULL)

Can you change the indentation from a tab to two spaces while you're here?
Attachment #534718 - Flags: feedback?(ted.mielczarek) → feedback+
Comment on attachment 534718 [details] [diff] [review]
move content/xul/*.xul tests to mochitest-chrome (1.0)

> :bz, can you verify these tests will be fine in mochitest-chrome:

Looks ok to me.
Attachment #534718 - Flags: review?(bzbarsky) → review+

Updated

6 years ago
Attachment #534718 - Flags: review+
(Assignee)

Comment 7

6 years ago
http://hg.mozilla.org/mozilla-central/rev/38f213874df7
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.