Closed
Bug 659266
Opened 14 years ago
Closed 13 years ago
Need a minimalistic Sync glyph for notifications
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
VERIFIED
FIXED
Firefox 7
Tracking | Status | |
---|---|---|
firefox5 | --- | unaffected |
firefox6 | --- | fixed |
People
(Reporter: mak, Assigned: shorlander)
References
Details
(Whiteboard: [inbound])
Attachments
(2 files, 2 obsolete files)
122.26 KB,
image/png
|
Details | |
8.42 KB,
patch
|
asa
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
bug 618913 landed with a 24px Sync icon, but UX would prefer a more minimalistic icon for it, replacing the icon is trivial, so it may land on central and Aurora. Tentatively assigning to Stephen.
Updated•14 years ago
|
Component: Firefox Sync: UI → Theme
Product: Mozilla Services → Firefox
QA Contact: sync-ui → theme
Assignee | ||
Comment 1•13 years ago
|
||
Adds low key images for the Sync notification.
Assignee | ||
Comment 2•13 years ago
|
||
Assignee | ||
Updated•13 years ago
|
Attachment #543204 -
Flags: review?(gavin.sharp)
Reporter | ||
Comment 3•13 years ago
|
||
it's really nice. A couple questions: 1. Is it expected that on gnomestripe we keep the current sync-24.png? 2. Why didn't you remove sync-24.png from pinstripe and winstripe? Should be unused now.
Assignee | ||
Comment 4•13 years ago
|
||
(In reply to comment #3) > it's really nice. > A couple questions: > 1. Is it expected that on gnomestripe we keep the current sync-24.png? Yes. It will work better than trying to match variable themes. > 2. Why didn't you remove sync-24.png from pinstripe and winstripe? Should be > unused now. Oh yeah, I should do that :) Forgot we added that just for this.
Assignee | ||
Comment 5•13 years ago
|
||
Removed the unused sync-24.png
Attachment #543204 -
Attachment is obsolete: true
Attachment #543204 -
Flags: review?(gavin.sharp)
Attachment #543254 -
Flags: review?(gavin.sharp)
Assignee | ||
Updated•13 years ago
|
Attachment #543254 -
Flags: review?(gavin.sharp) → review?(dolske)
Updated•13 years ago
|
Attachment #543254 -
Flags: review?(dolske) → review+
Reporter | ||
Comment 6•13 years ago
|
||
I think, for consistency, may make sense to rename the gnomestripe sync-24.png to sync-notification-24.png it may be confusing for future otherwise. Sorry if I didn't point this out before.
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Reporter | ||
Comment 7•13 years ago
|
||
I've renamed the icon in gnomestripe, for previous comment, moved in jar.mn according to the other themes.
Attachment #543254 -
Attachment is obsolete: true
Reporter | ||
Comment 8•13 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/8460bb7fb589
Keywords: checkin-needed
Whiteboard: [inbound]
Reporter | ||
Comment 9•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/8460bb7fb589
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 7
Reporter | ||
Comment 10•13 years ago
|
||
Comment on attachment 543767 [details] [diff] [review] Sync Glyph for the Panel Notification - 03 May we get beta approval on this icon replacement? I think the first impact of this notification is important, and we'll have that impact in Firefox 7. This change is a try to make the notification less intrusive to the user, since it's not intended to be annoying nor look like an advertisement.
Attachment #543767 -
Flags: approval-mozilla-beta?
Reporter | ||
Comment 11•13 years ago
|
||
ehr, in comment 5 I meant "we'll have that impact in Firefox 6"
Comment 12•13 years ago
|
||
Comment on attachment 543767 [details] [diff] [review] Sync Glyph for the Panel Notification - 03 approval for beta. did this make aurora?
Attachment #543767 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Reporter | ||
Comment 13•13 years ago
|
||
sure, it made Aurora.
Reporter | ||
Comment 14•13 years ago
|
||
http://hg.mozilla.org/releases/mozilla-beta/rev/6e78e6a73460
status-firefox5:
--- → unaffected
status-firefox6:
--- → fixed
Comment 15•13 years ago
|
||
Verified on 6.0 Beta, build 2: Mac: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:6.0) Gecko/20100101 Firefox/6.0 Windows 7: Mozilla/5.0 (Windows NT 6.1; rv:6.0) Gecko/20100101 Firefox/6.0 Windows XP: Mozilla/5.0 (Windows NT 5.1; rv:6.0) Gecko/20100101 Firefox/6.0 Linux: Mozilla/5.0 (X11; Linux i686; rv:6.0) Gecko/20100101 Firefox/6.0 Notifications to set up sync are visible (when bookmarking a website a message that promotes Sync is visible to the user)
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•