659268 - GCLI command parameters could use more advanced validation. Experiment.

Status: RESOLVED WONTFIX

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)

Description

[Joe Walker [:jwalker]]

Sometimes parameters need specific validation which can't be performed by the type system.

$ example --verbose --quiet

Another example could be resource names which are un-enumerable, and yet validatable.

If would be nice if we could add custom validation to be performed by the command line before the command is invoked for real.

Comment 1

[Joe Walker [:jwalker]]

See also https://github.com/joewalker/gcli/issues/6

Comment 2

[Joe Walker [:jwalker]]

The given example "--verbose --quiet" isn't great because we might be able to do better with "--output [verbose|quiet|default]" or similar.

This observation does not invalidate this bug however - there are times when more complex validation is needed.

The observation does point out that there are times when we can alter the command syntax to provide the same results without needing to write extra code.

Comment 3

[Joe Walker [:jwalker]]

See bug 683513

Comment 4

[Joe Walker [:jwalker]]

Moving GCLI bugs to Developer Tools: Console. Filter on 'baked beans are off'.

Comment 5

[Joe Walker [:jwalker]]

Triage. Filter on PEGASUS.

Comment 6

[Joe Walker [:jwalker]]

Triage, filter on TEABAGS

Comment 7

[Girish Sharma [:Optimizer]]

One more case where validation would be required:

screenshot command has 2 options 'chrome' and 'selector'

chrome enables chrome screenshot capturing rather than content; And selector lets us choose a node via its unique selector (#id.class)

when you do simply 

>> screenshot --selector h1.img

it takes screnshot of the image that is h1

but when you try to do the following:

>> screenshot --chrome --selector h1.img

the context of the selector should now be switched to chrome, so that I could do this:

>> screenshot --chrome --selector #webConsole

where #webConsole is a XUL element.

but right now what happens is that 'selector' option still tries to find the node in content context and there is no way to get the selector to match a chrome/XUL node.

Comment 8

[Joe Walker [:jwalker]]

New component triage. Filter on "Lobster Thermidor aux crevettes with a Mornay sauce"

Comment 9

[Joe Walker [:jwalker]]

Resetting priorities because these P* levels are very out of date.
Sorry for the bug spam. Filter on Lobster Thermidor

Comment 10

[Joe Walker [:jwalker]]

Triage. Filter on Lobster Thermidor.
Nice idea, but no need to keep on file.