Learn More links are broken in sync discovery dialogs

VERIFIED FIXED in Firefox 6

Status

Cloud Services
Firefox Sync: UI
--
critical
VERIFIED FIXED
6 years ago
4 years ago

People

(Reporter: tracy, Assigned: mak)

Tracking

unspecified
mozilla7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox6+ fixed)

Details

(Whiteboard: [verified-in-places])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
This is a follow up bug for bug 618913

STR:

1) Open the bookmarks dialog from the star or open the remember password dialog from the key at a password required site.
2) Click on the "Learn More" link

tested results:
Nothing happens

expected results:
taken to a page about how to setup/use Sync.
(Assignee)

Comment 1

6 years ago
This should be fixed if we retain the feature, if the patch is trivial enough we may get approval (should be trivial).
(Assignee)

Comment 2

6 years ago
Created attachment 534877 [details] [diff] [review]
patch v1.0

some thoughts:
1. I can't directly use <label> since it opens links in a new window (bug 263433)
2. I can't use OpenUILlinkIn(url, 'tab') because it respects browser.tabs.loadBookmarksInBackground, in this case the user requested more information, opening a background tab sounds crazy.
3. Since the user explicitly requests a context-switch, I close the panel, otherwise it would be a panel floating on a different page than the one that generated it.
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Attachment #534877 - Flags: review?(dolske)
tracking-firefox6: ? → +
Attachment #534877 - Flags: review?(dolske) → review+
(Assignee)

Comment 3

6 years ago
Since I plan to merge on Monday or similar, pushed to the branch
http://hg.mozilla.org/projects/places/rev/ee2caae41309
Whiteboard: [fixed-in-places]
(Reporter)

Comment 4

6 years ago
verified in places build from 20110602

Learn more links go to http://www.mozilla.com/en-US/mobile/sync/  and dialog is closed on link click.
Whiteboard: [fixed-in-places] → [verified-in-places]
(Assignee)

Comment 5

6 years ago
http://hg.mozilla.org/mozilla-central/rev/ee2caae41309
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
(Assignee)

Comment 6

6 years ago
Comment on attachment 534877 [details] [diff] [review]
patch v1.0

This is a basic functionality for the feature, if we want to retain the feature this bug has to be fixed.
The patch is simply adding an onclick handler.
Attachment #534877 - Flags: approval-mozilla-aurora?
Attachment #534877 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 7

6 years ago
http://hg.mozilla.org/releases/mozilla-aurora/rev/ec8b39089b68
status-firefox6: --- → fixed
(Reporter)

Updated

6 years ago
Status: RESOLVED → VERIFIED

Updated

4 years ago
Depends on: 919490
You need to log in before you can comment on or make changes to this bug.