Last Comment Bug 659340 - Add back paranoia on Frame life from last patch of bug 655084
: Add back paranoia on Frame life from last patch of bug 655084
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Layout (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: [:jesup] on pto until 2016/7/5 Randell Jesup
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-05-24 08:56 PDT by [:jesup] on pto until 2016/7/5 Randell Jesup
Modified: 2011-06-06 07:08 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Revert to older code for safety (1.08 KB, patch)
2011-05-24 13:18 PDT, [:jesup] on pto until 2016/7/5 Randell Jesup
ehsan: review+
mounir: checkin+
Details | Diff | Review

Description [:jesup] on pto until 2016/7/5 Randell Jesup 2011-05-24 08:56:32 PDT
In bug 655084, I had simplified the code at ehsan's request in a way that adds hidden assumptions about other code and the lifetime of a Frame.  It's more paranoid and safe to revert the the final version of that piece of the patch.  See the end of that bug for discussion.
Comment 1 [:jesup] on pto until 2016/7/5 Randell Jesup 2011-05-24 13:18:26 PDT
Created attachment 534869 [details] [diff] [review]
Revert to older code for safety

Is this sufficient, or do we need to block scripts too?
Comment 2 [:jesup] on pto until 2016/7/5 Randell Jesup 2011-05-29 23:23:38 PDT
Fix checked in as http://hg.mozilla.org/mozilla-central/rev/b3f26adf6b42

Note You need to log in before you can comment on or make changes to this bug.