Add back paranoia on Frame life from last patch of bug 655084

RESOLVED FIXED

Status

()

Core
Layout
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jesup, Assigned: jesup)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
In bug 655084, I had simplified the code at ehsan's request in a way that adds hidden assumptions about other code and the lifetime of a Frame.  It's more paranoid and safe to revert the the final version of that piece of the patch.  See the end of that bug for discussion.
(Assignee)

Updated

6 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

6 years ago
Created attachment 534869 [details] [diff] [review]
Revert to older code for safety

Is this sufficient, or do we need to block scripts too?
Attachment #534869 - Flags: review?(ehsan)
Attachment #534869 - Flags: review?(ehsan) → review+
(Assignee)

Updated

6 years ago
Assignee: nobody → rjesup
(Assignee)

Comment 2

6 years ago
Fix checked in as http://hg.mozilla.org/mozilla-central/rev/b3f26adf6b42
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
Attachment #534869 - Flags: checked-in+
Attachment #534869 - Flags: checked-in+ → checkin+
You need to log in before you can comment on or make changes to this bug.